Return-Path: Date: Fri, 28 Sep 2012 14:32:12 +0300 From: Johan Hedberg To: Anderson Lizardo Cc: Vinicius Costa Gomes , linux-bluetooth@vger.kernel.org Subject: Re: [PATCH v3 BlueZ 1/4] gatt: Add support for find included services Message-ID: <20120928113212.GA18666@x220> References: <1348526019-28402-1-git-send-email-vinicius.gomes@openbossa.org> <1348526019-28402-2-git-send-email-vinicius.gomes@openbossa.org> <20120928110833.GB14450@x220> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Lizardo, On Fri, Sep 28, 2012, Anderson Lizardo wrote: > On Fri, Sep 28, 2012 at 7:08 AM, Johan Hedberg wrote: > > Btw, if you guys are wondering why the stricter coding style checks, > > I've added the following to .git/hooks/pre-{commit,applypatch}: > > > > git diff --cached | ~/src/linux/scripts/checkpatch.pl --no-signoff --ignore INITIALISED_STATIC,NEW_TYPEDEFS,VOLATILE --show-types --mailback - > > > > You might want to do the same (with the correct path to checkpatch.pl)). > > And thanks to Luiz for the idea (he's using the same when applying > > patches). > > Thanks for the very useful tip! But which checkpatch.pl version are > you using? Mine (from bluetooth-next tree) lacks --ignore and > --show-types options. I'm using Linus' tree. Johan