Return-Path: Date: Fri, 28 Sep 2012 13:25:03 +0300 From: Johan Hedberg To: Andrzej Kaczmarek Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH v8 00/13] Heart Rate Profile plugin Message-ID: <20120928102503.GA25415@x220> References: <1348583267-16816-1-git-send-email-andrzej.kaczmarek@tieto.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1348583267-16816-1-git-send-email-andrzej.kaczmarek@tieto.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrzej, On Tue, Sep 25, 2012, Andrzej Kaczmarek wrote: > Changes since v7: > - rebased to latest upstream master (btd_profile changes) > > > Andrzej Kaczmarek (6): > heartrate: Add attio callbacks > heartrate: Discover HRS characteristics > heartrate: Discover Heart Rate Measurement CCC > heartrate: Add support to enable notifications > heartrate: Process measurement notifications > heartrate: Add support to reset Energy Expended > > Rafal Garbat (6): > heartrate: Add initial HRP client support > heartrate: Read Body Sensor Location characteristics > heartrate: Add HeartRateManager interface > heartrate: Add GetProperties method > heartrate: Add HeartRateWatcher interface to default policy > heartrate: Add test script > > Santiago Carot-Nemesio (1): > Heart Rate Profile (HRP) client API > > Makefile.am | 9 +- > Makefile.tools | 3 +- > doc/heartrate-api.txt | 84 +++++ > lib/uuid.h | 5 + > profiles/heartrate/heartrate.c | 826 +++++++++++++++++++++++++++++++++++++++++ > profiles/heartrate/heartrate.h | 27 ++ > profiles/heartrate/main.c | 52 +++ > profiles/heartrate/manager.c | 97 +++++ > profiles/heartrate/manager.h | 24 ++ > src/bluetooth.conf | 1 + > test/test-heartrate | 103 +++++ > 11 files changed, 1228 insertions(+), 3 deletions(-) > create mode 100644 doc/heartrate-api.txt > create mode 100644 profiles/heartrate/heartrate.c > create mode 100644 profiles/heartrate/heartrate.h > create mode 100644 profiles/heartrate/main.c > create mode 100644 profiles/heartrate/manager.c > create mode 100644 profiles/heartrate/manager.h > create mode 100755 test/test-heartrate All patches in this set have been applied. Thanks. One notable change I did when applying was to the sensor location API. The convention is to use lower case for string property values so I change the API and code to follow this. Johan