Return-Path: MIME-Version: 1.0 In-Reply-To: References: <747C1E83C744F44E9ACFB89FAEEC2C7B23D4A4EAC2@EXDCVYMBSTM005.EQ1STM.local> <747C1E83C744F44E9ACFB89FAEEC2C7B23D4AD9596@EXDCVYMBSTM005.EQ1STM.local> Date: Tue, 18 Sep 2012 11:28:51 +0300 Message-ID: Subject: Re: [PATCH BlueZ V6 1/5] AVRCP: Add TG Record to support AVRCP Browsing From: Luiz Augusto von Dentz To: Vani-dineshbhai PATEL X Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Vani, On Tue, Sep 18, 2012 at 11:05 AM, Luiz Augusto von Dentz wrote: > Hi Arun, > > On Tue, Sep 18, 2012 at 9:08 AM, Arun K. Singh wrote: >> Hi Luiz, folks, >> >> On Thu, Aug 30, 2012 at 10:38 AM, Vani-dineshbhai PATEL X >> wrote: >>> >>> From 7e32aecb2b13c6398108932e98fdd68faf9315d8 Mon Sep 17 00:00:00 2001 >>> From: Vani Patel >>> Date: Tue, 5 Jun 2012 13:44:30 +0530 >>> Subject: [PATCH BlueZ V6 1/5] AVRCP: Add TG Record to support AVRCP >>> Browsing >>> >>> Adds SDP record to support browsing >>> --- >>> audio/avctp.c | 4 ++-- >>> audio/avctp.h | 3 ++- >>> audio/avrcp.c | 28 ++++++++++++++++++++++++---- >>> 3 files changed, 28 insertions(+), 7 deletions(-) >>> >>> diff --git a/audio/avctp.c b/audio/avctp.c >>> index 074eabd..a20dba9 100644 >>> --- a/audio/avctp.c >>> +++ b/audio/avctp.c >> >> Any chance that have you been able to take a look at these patches and review? > > Im trying to validate the patches together with hcidump changes, but I > don't have any device that make use of the browsing channel. I was > expecting some updates regarding hcidump but it seems I will have to > take care of this myself. There seems to be some problem when I try to apply your patches git am complains: Applying: AVRCP: Add TG Record to support AVRCP Browsing fatal: corrupt patch at line 12 Patch failed at 0001 AVRCP: Add TG Record to support AVRCP Browsing It seems your patches are mangle using windows style line breaks. -- Luiz Augusto von Dentz