Return-Path: Message-ID: <1347456657.23874.29.camel@sirocco.hadess.net> Subject: Re: [PATCH] Add support for Logitech Harmony Adapter for PS3 From: Bastien Nocera To: Luiz Augusto von Dentz Cc: David Dillow , linux-bluetooth@vger.kernel.org Date: Wed, 12 Sep 2012 14:30:57 +0100 In-Reply-To: References: <1346378760.7976.2.camel@obelisk.thedillows.org> <20120907124559.GA16092@x220> <1347284864.3532.1.camel@sirocco.hadess.net> <1347394656.1606.10.camel@sirocco.hadess.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Em Wed, 2012-09-12 às 13:56 +0300, Luiz Augusto von Dentz escreveu: > Hi Bastien, > > On Tue, Sep 11, 2012 at 11:17 PM, Bastien Nocera wrote: > > Em Tue, 2012-09-11 às 17:21 +0300, Luiz Augusto von Dentz escreveu: > >> Hi Bastien, > >> > >> On Mon, Sep 10, 2012 at 10:03 PM, Luiz Augusto von Dentz > >> wrote: > >> > Hi Bastien, > >> > > >> > On Mon, Sep 10, 2012 at 4:58 PM, Luiz Augusto von Dentz > >> > wrote: > >> >> Hi Bastien, > >> >> > >> >> On Mon, Sep 10, 2012 at 4:47 PM, Bastien Nocera wrote: > >> >>> Em Mon, 2012-09-10 às 16:11 +0300, Luiz Augusto von Dentz escreveu: > >> >>>> Hi David, Bastien, > >> >>>> > >> >>>> So we are plannin to rid of the fakehid.c in favor of implementing it > >> >>>> properly inside the kernel similarly to what was done to wiimote, so > >> >>>> is there any obstacle for doing that? > >> >>>> > >> >>>> The kernel seems to already have some support for sixaxis in > >> >>>> drivers/hid/hid-sony.c, so I suppose the following would enable us to > >> >>>> use it: > >> >>> > >> >>> It won't. They're not the same hardware. > >> >> > >> >> What hardware is that then? And why wouldn't the kernel be able to > >> >> support even if it is a different driver? > >> > > >> > So what exactly are the difference between 0x0268 and 0x0306? And why > >> > sixpair.c save as 0x0268 while fakeinput.c uses 0x0306? > >> > > >> > Also, after fixing sixpair.c to be able to compile it does add to the > >> > storage but it does not create any object until bluetoothd is > >> > restarted and even after restart it does not allow the device to > >> > connect because it does has the record (although this can be fixed by > >> > automatically add the UUID once we find out it is attempt to connect). > >> > >> So apparently the 0x0306 device is the br remote controller, not the > >> sixaxis joystick, sorry about the confusion. > > > > Completely different protocols for the devices, indeed. > > > >> Anyway regardless of > >> being a different device I thing we should move this code to kernel as > >> it was done for wiimote. > > > > Certainly, but until somebody writes the code (I already have at least 3 > > drivers to submit to the kernel that I've not had time to handle, > > include one Bluetooth device), I think it would be nice not to drop > > support for the existing hardware. The cost of David's patch is close to > > none. > > Do you have any code already? Why would I? I don't have time to handle the 3 other drivers, and my BD remote is now in a shipping container. > Anyway it is now removed from upstream, Why would you want to do that when we don't have a replacement in the kernel yet? I just spent time getting that timeout patch upstreamed, Johan even merged up David's patch, and 3 days after you remove the whole functionality. > I will try to get one of these devices myself and start writing some > code if you don't have it done already. Around $20: http://www.amazon.com/Media-Blu-ray-Remote-Control-Playstation-3/dp/B0050SX9I2/ Really not happy we're removing the functionality without having adequate replacement. That's not something you do with hardware enablement. I'm ready to take bets on the length of time where there's no support for the remote in distributions because it was removed in bluez, and not supported in the kernel.