Return-Path: Date: Thu, 25 Oct 2012 08:29:26 -0700 (PDT) From: Mat Martineau To: Andrei Emeltchenko cc: Marcel Holtmann , Fengguang Wu , Gustavo Padovan , linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] Bluetooth: l2cap_physical_cfm() can be static In-Reply-To: <20121025071307.GA2502@aemeltch-MOBL1> Message-ID: References: <508863c1.QTbySMnQ9kj6jDZz%fengguang.wu@intel.com> <20121024220131.GB3030@joana> <20121025002608.GA10418@localhost> <1351130134.1785.85.camel@aeonflux> <20121025071307.GA2502@aemeltch-MOBL1> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed List-ID: Hi - On Thu, 25 Oct 2012, Andrei Emeltchenko wrote: > Hi, > > On Wed, Oct 24, 2012 at 06:55:34PM -0700, Marcel Holtmann wrote: >> Hi Fengguang, >> >>> Signed-off-by: Fengguang Wu >>> --- >>> net/bluetooth/l2cap_core.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> --- linux-next.orig/net/bluetooth/l2cap_core.c 2012-10-25 08:23:52.456742699 +0800 >>> +++ linux-next/net/bluetooth/l2cap_core.c 2012-10-25 08:23:55.056742760 +0800 >>> @@ -4569,7 +4569,7 @@ static void l2cap_do_move_cancel(struct >>> l2cap_ertm_send(chan); >>> } >>> >>> -void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id, >>> +static void l2cap_physical_cfm(struct l2cap_chan *chan, int result, u8 local_amp_id, >>> u8 remote_amp_id) >> >> I rather wait for Mat to ACK or NACK this one. Maybe it is an oversight >> or we need that later on to be actually public. > > Agree with Marcel here. This shall be public. Yes, it does need to be public. Andrei will need to call it from the AMP physical link code, but I'm not sure exactly where (HCI event handling or somewhere in amp.c or a2mp.c). -- Mat Martineau Employee of Qualcomm Innovation Center, Inc. Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation