Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1352754221-29672-1-git-send-email-anderson.lizardo@openbossa.org> Date: Tue, 13 Nov 2012 08:52:43 -0400 Message-ID: Subject: Re: [PATCH BlueZ] build: Fix make distcheck for input plugin From: Anderson Lizardo To: Lucas De Marchi Cc: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Lucas, On Tue, Nov 13, 2012 at 8:21 AM, Lucas De Marchi wrote: > On Mon, Nov 12, 2012 at 7:03 PM, Anderson Lizardo > wrote: >> suspend.c is a symlink generated at build time, therefore it should be >> created on build directory. Additionally, it is necessary to add >> -I$(srcdir)/profiles/input to CPPFLAGS so suspend.h can be found (the >> compiler does not follow symlinks prior to resolving #include >> directives). >> --- >> Makefile.am | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/Makefile.am b/Makefile.am >> index d49e8a0..c398e74 100644 >> --- a/Makefile.am >> +++ b/Makefile.am >> @@ -366,6 +366,10 @@ if MCAP >> AM_CPPFLAGS += -I$(builddir)/health >> endif >> >> +if HOGPLUGIN >> +AM_CPPFLAGS += -I$(srcdir)/profiles/input >> +endif > > Humn... maybe we need to review these CPPFLAGS for plugins. Appending > it to AM_CPPFLAGS means that every single source file has > "-I$(srcdir)/profiles/input". Even those sources not at all related to > HOGPLUGIN. > > However the only way I can think to fix it is by creating convenience > libs since autofoo doesn't support CPPFLAGS per source file. I agree it is not the best solution. Actually, I think we can overcome the problem completely by getting rid of symlinks for "drivers" (like sap-{u8500,dummy}.c, suspend-dummy.c, telephony-{dummy,maemo5,maemo6,ofono}.c) and having everything built-in and enabled/disabled based on which D-Bus services are running on the system (or, if not possible, by using config options). This would also help with spotting build breakages, since all BlueZ code could be compiled by a single "./bootstrap-configure && make" call. This was suggested by Marcel sometime ago on the mailing list, but no one has come up with actually implementing this. This commit for now will fix make distcheck breakage, and in my tests it did not break anything else. I will propose a TODO entry for this, so someone can work on it. Best Regards, -- Anderson Lizardo Instituto Nokia de Tecnologia - INdT Manaus - Brazil