Return-Path: From: Luiz Augusto von Dentz To: linux-bluetooth@vger.kernel.org Subject: [PATCH BlueZ 2/2 v2] attrib: Don't attempt to unregister event id 0 Date: Thu, 31 Jan 2013 09:33:53 -0600 Message-Id: <1359646436-8113-4-git-send-email-luiz.dentz@gmail.com> In-Reply-To: <1359646436-8113-1-git-send-email-luiz.dentz@gmail.com> References: <1359646436-8113-1-git-send-email-luiz.dentz@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: From: Luiz Augusto von Dentz Id 0 is considered invalid so the code should not even try to lookup for it in the event list instead print a warning and return FALSE immediatelly. --- attrib/gattrib.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/attrib/gattrib.c b/attrib/gattrib.c index 58f19d0..01c19f9 100644 --- a/attrib/gattrib.c +++ b/attrib/gattrib.c @@ -719,6 +719,11 @@ gboolean g_attrib_unregister(GAttrib *attrib, guint id) struct event *evt; GSList *l; + if (id == 0) { + warn("%s: invalid id", __FUNCTION__); + return FALSE; + } + l = g_slist_find_custom(attrib->events, GUINT_TO_POINTER(id), event_cmp_by_id); if (l == NULL) -- 1.8.1