Return-Path: Message-ID: <1359532892.9998.1.camel@aeonflux> Subject: Re: [PATCH 3/5] Bluetooth: Refactor hci_conn_disconnect From: Marcel Holtmann To: Andre Guedes Cc: linux-bluetooth@vger.kernel.org Date: Wed, 30 Jan 2013 09:01:32 +0100 In-Reply-To: <1359500396-8184-3-git-send-email-andre.guedes@openbossa.org> References: <1359500396-8184-1-git-send-email-andre.guedes@openbossa.org> <1359500396-8184-3-git-send-email-andre.guedes@openbossa.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andre, > This patch does a trivial refactoring in hci_conn_disconnect function. > > Signed-off-by: Andre Guedes > --- > net/bluetooth/hci_conn.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/net/bluetooth/hci_conn.c b/net/bluetooth/hci_conn.c > index 28cfa72..4925a02 100644 > --- a/net/bluetooth/hci_conn.c > +++ b/net/bluetooth/hci_conn.c > @@ -249,15 +249,12 @@ static void hci_conn_disconnect(struct hci_conn *conn) > __u8 reason = hci_proto_disconn_ind(conn); > > switch (conn->type) { > - case ACL_LINK: > - case LE_LINK: > - case SCO_LINK: > - case ESCO_LINK: > - hci_acl_disconn(conn, reason); > - break; > case AMP_LINK: > hci_amp_disconn(conn, reason); > break; > + default: > + hci_acl_disconn(conn, reason); > + break; > } just make it one patch that fixes all cases. Trying to make 3 patches out of this is just confusing. Rather write a proper commit message that explains it all. Regards Marcel