Return-Path: Date: Tue, 22 Jan 2013 15:56:50 -0300 From: Vinicius Costa Gomes To: =?iso-8859-1?Q?Jo=E3o?= Paulo Rechi Vita Cc: linux-bluetooth@vger.kernel.org, luiz.dentz@gmail.com Subject: Re: [PATCH BlueZ 2/2] avctp: Receive and silent ignore Vol Up/Down operations Message-ID: <20130122185650.GA1119@samus> References: <1358878703-8100-1-git-send-email-jprvita@openbossa.org> <1358878703-8100-3-git-send-email-jprvita@openbossa.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 In-Reply-To: <1358878703-8100-3-git-send-email-jprvita@openbossa.org> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Joao, On 15:18 Tue 22 Jan, Jo?o Paulo Rechi Vita wrote: > The AVRCP spec mandates to support 'volume up' and 'volume down' > operations when claiming support for Category 2 TG. > --- > profiles/audio/avctp.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/profiles/audio/avctp.c b/profiles/audio/avctp.c > index f7e607e..4ab6d6d 100644 > --- a/profiles/audio/avctp.c > +++ b/profiles/audio/avctp.c > @@ -214,6 +214,8 @@ static struct { > uint8_t avc; > uint16_t uinput; > } key_map[] = { > + { "VOLUME UP", AVC_VOLUME_UP, KEY_VOLUMEUP}, > + { "VOLUME DOWN", AVC_VOLUME_DOWN, KEY_VOLUMEDOWN}, > { "PLAY", AVC_PLAY, KEY_PLAYCD }, > { "STOP", AVC_STOP, KEY_STOPCD }, > { "PAUSE", AVC_PAUSE, KEY_PAUSECD }, > @@ -968,6 +970,9 @@ static void init_uinput(struct avctp *session) > > dev = manager_get_audio_device(session->device, FALSE); > > + session->key_quirks[AVC_VOLUME_UP] |= QUIRK_IGNORE; > + session->key_quirks[AVC_VOLUME_DOWN] |= QUIRK_IGNORE; > + Having a quirk that applies to every device, doesn't seem to map to the meaning of 'quirk', i.e. if everybody has the same quirk, it is the norm ;-) Cheers, -- Vinicius