Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.2 \(1499\)) Subject: Re: [PATCH v4 00/26] Bluetooth: Management interface fixes From: Marcel Holtmann In-Reply-To: <1363198337-3896-1-git-send-email-johan.hedberg@gmail.com> Date: Fri, 15 Mar 2013 13:29:24 -0700 Cc: linux-bluetooth@vger.kernel.org Message-Id: <434BC258-2159-417A-80B5-077E8D0979F3@holtmann.org> References: <1363198337-3896-1-git-send-email-johan.hedberg@gmail.com> To: Johan Hedberg Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Johan, > I'm sending all 26 patches I had pending in my local tree, as requested > by Marcel. The first six in this set are identical to my patch set > titled "[PATCH v3 0/6] Bluetooth: HCI command synchronisation fixes". > > Johan > > ---------------------------------------------------------------- > Johan Hedberg (26): > Bluetooth: Move power on HCI command updates to their own function > Bluetooth: Update mgmt powered HCI commands to use async requests > Bluetooth: Wait for HCI command completion with mgmt_set_powered > Bluetooth: Fix busy condition testing for EIR and class updates > Bluetooth: Fix UUID/class mgmt command response synchronization > Bluetooth: Remove useless HCI_PENDING_CLASS flag > Bluetooth: Add a define for the HCI persistent flags mask > Bluetooth: Clear non-persistent flags when closing HCI device > Bluetooth: Fix clearing flags on power off before notifying mgmt > Bluetooth: Fix waiting for EIR update when setting local name > Bluetooth: Handle AD updating through an async request > Bluetooth: Fix local name setting for LE-only controllers > Bluetooth: Fix setting local name to the existing value > Bluetooth: Use an async request for mgmt_set_connectable > Bluetooth: Fix fast connectable response sending > Bluetooth: Limit fast connectable support to >= 1.2 controllers > Bluetooth: Fix error response for simultaneous fast connectable commands > Bluetooth: Add proper flag for fast connectable mode > Bluetooth: Refactor fast connectable HCI commands > Bluetooth: Disable fast connectable when disabling connectable > Bluetooth: Add reading of page scan parameters > Bluetooth: Update page scan parameters after successful write commands > Bluetooth: Fix updating page scan parameters when not necessary > Bluetooth: Fix fast connectable state when enabling page scan > Bluetooth: Simplify address parameters of user_pairing_resp() > Bluetooth: Fix PIN/Confirm/Passkey response parameters > > include/net/bluetooth/hci.h | 21 +- > include/net/bluetooth/hci_core.h | 8 +- > net/bluetooth/hci_core.c | 42 ++- > net/bluetooth/hci_event.c | 97 +++++- > net/bluetooth/mgmt.c | 680 ++++++++++++++++++++++++++------------ > 5 files changed, 599 insertions(+), 249 deletions(-) besides my one comment about the mask clearing, I did not see anything obvious. So this patch set is fine with me. However as we discussed there are cleanups to be done in some areas after this gets merged. Regards Marcel