Return-Path: MIME-Version: 1.0 In-Reply-To: References: Date: Fri, 1 Mar 2013 15:20:39 +0200 Message-ID: Subject: Re: Bluez 5.2 A2DP: "Unable to select SEP" From: Luiz Augusto von Dentz To: Mikel Astiz Cc: Scott James Remnant , "Von Dentz, Luiz" , Marcel Holtmann , "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 List-ID: HI Mikel, On Fri, Mar 1, 2013 at 12:47 PM, Mikel Astiz wrote: > Hi, > > On Thu, Feb 28, 2013 at 10:15 PM, Scott James Remnant wrote: >> Enabling both works for me; and leave it up to the audio manager to >> actually provide the Endpoints it wants to support. >> >> Scott >> >> On Thu, Feb 28, 2013 at 1:14 PM, Von Dentz, Luiz >> wrote: >> >>> Hi Marcel, Scott, >>> >>> On Thu, Feb 28, 2013 at 10:49 PM, Marcel Holtmann wrote: >>>> Hi Scott, >>>> >>>> >>>>>> On Thu, Feb 28, 2013 at 9:51 PM, Scott James Remnant wrote: >>>>>>> I'm having some difficulties connecting up A2DP in BlueZ 5.2, and I'm >>>>>>> sure I'm just missing something obvious so would appreciate a second >>>>>>> set of eyes. >>>>>>> >>>>>>> I had thought that to send to an A2DP Sink on a device, I needed an >>>>>>> A2DP Source endpoint at my end, but when I try and register that >>>>>>> endpoint I just get org.bluez.Error.NotSupported >>>>>> >>>>>> Check your /etc/bluetooth/audio.conf, you must have disabled it for some reason. >>>>>> >>>>> >>>>> There isn't an audio.conf shipped with BlueZ 5.2; checking >>>>> profiles/audio/manager.c it has: >>>>> >>>>> static struct enabled_interfaces enabled = { >>>>> .sink = TRUE, >>>>> .source = FALSE, >>>>> .control = TRUE, >>>>> }; >>>>> >>>>> This seems bizarre that registering audio sinks (which I read as >>>>> sending A2DP from the device to the host) is enabled by default, but >>>>> not the more usual registering of an audio source (to send to an A2DP >>>>> sink on the device). >>> >>> Yep, it was the result of changing the roles, I guess we should enable >>> them both by default and if the distro don't want one of them just >>> disable in the config file. >>> >>>> we want to move to a state where BlueZ works out-of-the-box with no extra config files needed. So I think we should just fix this and always have at least one sink and one source present. >>>> >>>> Or if that causes issues, then at least have this depend on PA (or some other audio manager) making that call for us. The default behaviour needs to just work. >>> >>> By default I would enable them both as nowadays both should work, well >>> I guess this is valid for every profile that is not market as >>> experimental it should be enabled by default, so how about the >>> following patch: >>> >>> diff --git a/profiles/audio/manager.c b/profiles/audio/manager.c >>> index 934227e..163fcba 100644 >>> --- a/profiles/audio/manager.c >>> +++ b/profiles/audio/manager.c >>> @@ -72,7 +72,7 @@ static GSList *devices = NULL; >>> >>> static struct enabled_interfaces enabled = { >>> .sink = TRUE, >>> - .source = FALSE, >>> + .source = TRUE, >>> .control = TRUE, >>> }; >>> >>> Or maybe I just remove the whole enabled thing and have the core to handle this. > > I agree enabling all is the best choice. > > In fact, I've seen that distros like Ubuntu have patched BlueZ (4.101) > to enable them by default (in the source code), and nobody seemed to > complain about this so far. Ive send a set removing this from audio plugin, let me know if you have some comments. -- Luiz Augusto von Dentz