Return-Path: MIME-Version: 1.0 In-Reply-To: <20130430064304.GA29654@x220> References: <1367300704-703-1-git-send-email-andre.guedes@openbossa.org> <1367300704-703-2-git-send-email-andre.guedes@openbossa.org> <20130430064304.GA29654@x220> Date: Tue, 30 Apr 2013 15:06:04 -0300 Message-ID: Subject: Re: [PATCH v2 01/13] Bluetooth: Fix start_discovery for LE-only controllers From: Andre Guedes To: linux-bluetooth@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Johan, On Tue, Apr 30, 2013 at 3:43 AM, Johan Hedberg wrote: > Hi Andre, > > On Tue, Apr 30, 2013, Andre Guedes wrote: >> LE-only controllers don't have local extended features (see commit >> c73eee9172bf061202c75ad4d16506a7efd04d1c). Thus, lmp_host_le_capable >> helper is not applicable and we should use test_bit(HCI_LE_ENABLED) >> to check if the host supports LE. Otherwise, start_discovery will >> always fail for LE-only controllers. >> >> This misbehavior can be easily checked by running mgmt-tester tool >> (test "Start Discovery - Success 2" will fail). >> >> Signed-off-by: Andre Guedes >> --- >> net/bluetooth/mgmt.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) > > I already sent a patch for this last Wednesday: > > Bluetooth: Fix checks for LE support on LE-only controllers > > So this patch can be ignored. Great, I'll remove it from the v3 patch set. Thanks, Andre