Return-Path: Content-Type: text/plain; charset=US-ASCII Mime-Version: 1.0 (Mac OS X Mail 6.3 \(1503\)) Subject: Re: [PATCH v7 0/5] input: Connectability From: Marcel Holtmann In-Reply-To: Date: Mon, 22 Apr 2013 12:27:55 -0700 Cc: linux-bluetooth , keybuk Message-Id: <51409ECB-5F03-473F-A257-72EE1540B571@holtmann.org> References: <1366149521-26908-1-git-send-email-deymo@chromium.org> <553F95A2-59E2-4D2E-BDB6-4AEF5E45B3FD@holtmann.org> To: Alex Deymo Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Alex, >> However I do have a general question, do we need the new D-Bus API if we do an auto-reconnect handling? If so, do we need to indicate that the we are currently in auto-reconnect mode and/or cancel it when connecting attempts via other means happen. > > We still need the new D-Bus API to let the UI know that it can't > reconnect to the device because the device is not supposed to normally > accept connections (ReconnectMode is "device" (or "none" if such a > device exists)). This allows the UI to instruct the user to go and > move the mouse to reconnect or press that hidden "connect" button in > his device to reconnect it if the device had lost the pairing. If the > ReconnectMode is "device", the meaning of Device1.Connected property > changes a bit, since the fact that my mouse is disconnected right now > doesn't mean that it is not working as intended or that it should be > connected. I might have should answered this email with an acknowledged and understood comment. Sorry about that. My original comment still stands. I am fine with this patch set, but leave it up to Johan to make the final to apply it. > The auto-reconnect is implied and required by the Bluetooth HID spec > for example in cases where ReconnectMode is "host". I don't think we > should indicate that we are currently following the spec. The > auto-reconnect attempts are canceled when the device is reconnected > for some reason (because of this auto-reconnect or not) or when the > device is marked for deletion, even if the removal is during the > auto-reconnect process. Sounds good. Regards Marcel