Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1365628753-16774-1-git-send-email-deymo@chromium.org> <1365628753-16774-3-git-send-email-deymo@chromium.org> From: Alex Deymo Date: Thu, 11 Apr 2013 10:00:53 -0700 Message-ID: Subject: Re: [PATCH 2/6] plugins: Extend the pin code callback with the call number To: Marcel Holtmann Cc: linux-bluetooth Content-Type: text/plain; charset=ISO-8859-1 List-ID: On Wed, Apr 10, 2013 at 10:06 PM, Marcel Holtmann wrote: > so I do not think that "count" is a really good name here. Wouldn't it be better to call it "attempt" or something like that? No strong preference. "attempt" looks good. > And I prefer to make these things unsigned if we are not planning to have -1 handed to it. Actually, I'm using a -1 internally in the struct pincb_iter to mark that the iterator reached the end (see pincb_iter_end()), but it is never passed to the plugin.