Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1368073016-28434-1-git-send-email-lucas.demarchi@profusion.mobi> <1368073016-28434-5-git-send-email-lucas.demarchi@profusion.mobi> From: Lucas De Marchi Date: Thu, 9 May 2013 09:12:05 -0300 Message-ID: Subject: Re: [PATCH BlueZ 05/26] attrib: Get rid of guint* types To: Anderson Lizardo Cc: BlueZ development Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Anderson, On Thu, May 9, 2013 at 7:45 AM, Anderson Lizardo wrote: > Hi Lucas, > > On Thu, May 9, 2013 at 12:16 AM, Lucas De Marchi > wrote: >> guint -> unsigned int >> guint8 -> uint8_t >> guint16 -> uint16_t >> guint32 -> uint32_t >> guint64 -> uint64_t >> >> Add "#include " where appropriate and prefer this one over >> stdint.h. >> --- >> attrib/att.c | 2 +- >> attrib/gatt.c | 124 ++++++++++++++++++++++++++------------------------- >> attrib/gatt.h | 33 +++++++------- >> attrib/gattrib.c | 51 ++++++++++----------- >> attrib/gattrib.h | 21 +++++---- >> attrib/gatttool.c | 19 ++++---- >> attrib/interactive.c | 35 ++++++++------- >> 7 files changed, 148 insertions(+), 137 deletions(-) >> >> diff --git a/attrib/att.c b/attrib/att.c >> index d2b78bd..e196fa3 100644 >> --- a/attrib/att.c >> +++ b/attrib/att.c >> @@ -27,7 +27,7 @@ >> #endif >> >> #include >> -#include >> +#include >> #include > > Any reason to include inttypes.h instead of just stdint.h? Are we > using any of the PRI* format conversion macros? The reason is to be able to use PRI formats without having to change the include later. Lucas De Marchi