Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\)) Subject: Re: [PATCH 1/1] Bluetooth: Fix ACL alive for long in case of non pariable devices From: Marcel Holtmann In-Reply-To: <1375025201-18139-1-git-send-email-syamsidhardh@gmail.com> Date: Sun, 28 Jul 2013 15:13:56 -0700 Cc: linux-bluetooth@vger.kernel.org, Syam Sidhardhan Message-Id: References: <1375025201-18139-1-git-send-email-syamsidhardh@gmail.com> To: Syam Sidhardhan Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Syam, > For certain devices (ex: HID mouse), support for authentication, > pairing and bonding is optional. For such devices, the ACL alive > for too long after the L2CAP disconnection. > > To avoid the ACL alive for too long after L2CAP disconnection, reset the ACL > disconnect timeout back to HCI_DISCONN_TIMEOUT during L2CAP connect. > > While merging the commit id:a9ea3ed9b71cc3271dd59e76f65748adcaa76422 > this issue might have introduced. > > Signed-off-by: Sang-Ki Park > Signed-off-by: Chan-yeol Park > Signed-off-by: Jaganath Kanakkassery > Signed-off-by: Syam Sidhardhan > --- > v1 -> Modified the code as per the latest code. > v2 -> Add descriptive comment as per Marcel request. > v3 -> Moved from l2cap_conn_ready() to l2cap_connect() inorder to fix remote > non ssp pairing timeout. Generated the patch based on bluetooth.git tree. > > net/bluetooth/l2cap_core.c | 7 +++++++ > 1 file changed, 7 insertions(+) is the any chance you have btmon or hcidump traces that would show this kind of behavior. Adding these to the commit message might be really helpful in case we have understand again why we did this. Regards Marcel