Return-Path: <cyrus@holtmann.org>
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
Subject: Re: [PATCH 3/8] Bluetooth: Add Set Connectionless Slave Broadcast Data Command
From: Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <1380705078-22154-4-git-send-email-dh79.pyun@samsung.com>
Date: Wed, 2 Oct 2013 11:33:30 +0200
Cc: linux-bluetooth@vger.kernel.org, steve.jun@samsung.com,
	DoHyun Pyun <dh79.pyun@samsung.com>,
	C S Bhargava <cs.bhargava@samsung.com>
Message-Id: <BE9A995C-B5FA-4408-8A73-0AE575794C82@holtmann.org>
References: <1380705078-22154-1-git-send-email-dh79.pyun@samsung.com> <1380705078-22154-4-git-send-email-dh79.pyun@samsung.com>
To: Dohyun Pyun <re20sfree@gmail.com>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Dohyun,

> The Set_Connectionless_Slave_Broadcast_Data command provides the
> ability for the Host to set Connectionless Slave Broadcast data in
> the BR/EDR Controller.
> 
> The Core Spec Addendum 4 adds this command in part B Connectionless
> Slave Broadcast.
> 
> Bluetooth Core Specification Addendum 4 - Page 93
> 
> "7.3.88 Set Connectionless Slave Broadcast Data Command [New Section]
> ...
> If connectionless slave broadcast mode is disabled, this data shall be
> kept by the BR/EDR Controller and used once connectionless slave broadcast
> mode is enabled. If connectionless slave broadcast mode is enabled,
> and this command is successful, this data will be sent starting with
> the next Connectionless Slave Broadcast instant.
> 
> The Data_Length field may be zero, in which case no data needs to be
> provided.
> 
> The Host may fragment the data using the Fragment field in the command. If
> the combined length of the fragments exceeds the capacity of the largest
> allowed packet size specified in the Set Connectionless Slave Broadcast
> command, all fragments associated with the data being assembled shall be
> discarded and the Invalid HCI Command Parameters error (0x12) shall be
> returned."
> 
> Signed-off-by: Dohyun Pyun <dh79.pyun@samsung.com>
> Signed-off-by: C S Bhargava <cs.bhargava@samsung.com>
> ---
> include/net/bluetooth/hci.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
> 
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index 28294ac..d5a0da0 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -35,6 +35,8 @@
> 
> #define HCI_MAX_AMP_ASSOC_SIZE	672
> 
> +#define HCI_MAX_CLB_DATA_SIZE	252
> +

I have no idea what CLB stands for and how that got derived from connection slave broadcast.

Regards

Marcel