Return-Path: Date: Mon, 25 Nov 2013 16:01:54 +0200 From: Johan Hedberg To: Ravi kumar Veeramally Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH 1/4] android: Add CAP_NET_RAW capability Message-ID: <20131125140154.GA24659@x220.p-661hnu-f1> References: <1385387369-3015-1-git-send-email-ravikumar.veeramally@linux.intel.com> <1385387369-3015-2-git-send-email-ravikumar.veeramally@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1385387369-3015-2-git-send-email-ravikumar.veeramally@linux.intel.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Ravi, On Mon, Nov 25, 2013, Ravi kumar Veeramally wrote: > CAP_NET_RAW capability is required to up the bnep interfaces > in android environment. > --- > android/main.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/android/main.c b/android/main.c > index c9733f3..bfd2a87 100644 > --- a/android/main.c > +++ b/android/main.c > @@ -506,6 +506,7 @@ static bool set_capabilities(void) > header.pid = 0; > > cap.effective = cap.permitted = > + CAP_TO_MASK(CAP_NET_RAW) | > CAP_TO_MASK(CAP_NET_ADMIN) | > CAP_TO_MASK(CAP_NET_BIND_SERVICE); > cap.inheritable = 0; Would you then say that commit 9bda7e8c2130de9a3340ebd0e6cc1dedc2eae338 is incorrect? A quick grep doesn't show any instances of checking this capability in the BNEP code of the kernel. Exactly which system call is it that needs it? If you answered positively to my first question, please send a patch for that as well. Johan