Return-Path: From: Ravi kumar Veeramally To: linux-bluetooth@vger.kernel.org Cc: Ravi kumar Veeramally Subject: [PATCH_v4 10/12] android/hid: Handle invalid parameters in HAL Date: Tue, 5 Nov 2013 23:09:16 +0200 Message-Id: <1383685758-3900-11-git-send-email-ravikumar.veeramally@linux.intel.com> In-Reply-To: <1383685758-3900-1-git-send-email-ravikumar.veeramally@linux.intel.com> References: <1383685758-3900-1-git-send-email-ravikumar.veeramally@linux.intel.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: --- android/hal-hidhost.c | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/android/hal-hidhost.c b/android/hal-hidhost.c index fe68fe7..815902b 100644 --- a/android/hal-hidhost.c +++ b/android/hal-hidhost.c @@ -204,9 +204,8 @@ static bt_status_t hh_get_protocol(bt_bdaddr_t *bd_addr, case BTHH_BOOT_MODE: cmd.mode = HAL_HID_BOOT_PROTOCOL; break; - case BTHH_UNSUPPORTED_MODE: - cmd.mode = HAL_HID_UNSUPPORTED_PROTOCOL; - break; + default: + return BT_STATUS_PARM_INVALID; } return hal_ipc_cmd(HAL_SERVICE_ID_HIDHOST, @@ -236,9 +235,8 @@ static bt_status_t hh_set_protocol(bt_bdaddr_t *bd_addr, case BTHH_BOOT_MODE: cmd.mode = HAL_HID_BOOT_PROTOCOL; break; - case BTHH_UNSUPPORTED_MODE: - cmd.mode = HAL_HID_UNSUPPORTED_PROTOCOL; - break; + default: + return BT_STATUS_PARM_INVALID; } return hal_ipc_cmd(HAL_SERVICE_ID_HIDHOST, @@ -275,6 +273,8 @@ static bt_status_t hh_get_report(bt_bdaddr_t *bd_addr, case BTHH_FEATURE_REPORT: cmd.type = HAL_HID_FEATURE_REPORT; break; + default: + return BT_STATUS_PARM_INVALID; } return hal_ipc_cmd(HAL_SERVICE_ID_HIDHOST, HAL_OP_HID_GET_REPORT, @@ -309,6 +309,8 @@ static bt_status_t hh_set_report(bt_bdaddr_t *bd_addr, case BTHH_FEATURE_REPORT: cmd.type = HAL_HID_FEATURE_REPORT; break; + default: + return BT_STATUS_PARM_INVALID; } return hal_ipc_cmd(HAL_SERVICE_ID_HIDHOST, HAL_OP_HID_SET_REPORT, -- 1.8.1.2