Return-Path: Date: Mon, 30 Dec 2013 23:18:06 +0100 From: Pavel Machek To: Marcel Holtmann Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , =?utf-8?B?0JjQstCw0LnQu9C+INCU0LjQvNC40YLRgNC+0LI=?= , "Gustavo F. Padovan" , Johan Hedberg , linux-kernel , "linux-bluetooth@vger.kernel.org development" , Ville Tervo , Sebastian Reichel Subject: Re: [PATCH v2] Bluetooth: Add hci_h4p driver Message-ID: <20131230221806.GA32561@amd.pavel.ucw.cz> References: <1379703710-5757-1-git-send-email-pali.rohar@gmail.com> <1727897.LBX8128hIo@izba> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: List-ID: Hi! > > +config BT_HCIH4P > > + tristate "HCI driver with H4 Nokia extensions" > > + depends on BT && ARCH_OMAP > > Since then we moved away from doing hci_* prefix of drivers since that is misleading. See btusb.ko, btmrvl_sdio.ko etc. > > So this might be better named BT_NOK_H4P or BT_NOKIA_H4P and the module named btnok_h4p.ko or btnokia_h4p.ko. > Pali, please apply :-). Pavel commit b724166911dcdae2c43170ce4040427c00e834e3 Author: Pavel Date: Mon Dec 30 23:16:25 2013 +0100 Rename nokia h4p driver object to btnokia_h4p.ko. Signed-off-by: Pavel Machek diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig index 9d46f23..a53e8c7 100644 --- a/drivers/bluetooth/Kconfig +++ b/drivers/bluetooth/Kconfig @@ -251,5 +251,5 @@ config BT_NOKIA_H4P support for H4+ Bluetooth chip with vendor-specific H4 extensions. Say Y here to compile support for h4 extended devices into the kernel - or say M to compile it as module (hci_h4p). + or say M to compile it as module (btnokia_h4p). endmenu diff --git a/drivers/bluetooth/Makefile b/drivers/bluetooth/Makefile index c286dbe..a5ed271 100644 --- a/drivers/bluetooth/Makefile +++ b/drivers/bluetooth/Makefile @@ -31,7 +31,7 @@ hci_uart-$(CONFIG_BT_HCIUART_ATH3K) += hci_ath.o hci_uart-$(CONFIG_BT_HCIUART_3WIRE) += hci_h5.o hci_uart-objs := $(hci_uart-y) -obj-$(CONFIG_BT_NOKIA_H4P) += hci_h4p.o -hci_h4p-objs := nokia_core.o nokia_fw.o nokia_uart.o nokia_fw-csr.o \ +obj-$(CONFIG_BT_NOKIA_H4P) += btnokia_h4p.o +btnokia_h4p-objs := nokia_core.o nokia_fw.o nokia_uart.o nokia_fw-csr.o \ nokia_fw-bcm.o nokia_fw-ti1273.o -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html