Return-Path: From: Andrei Emeltchenko To: linux-bluetooth@vger.kernel.org Subject: [PATCH] android/tester: Fix closing invalid fd Date: Wed, 11 Dec 2013 13:44:58 +0200 Message-Id: <1386762298-31678-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: From: Andrei Emeltchenko This fixes possible closing invalid fd in a case socket() fails --- android/android-tester.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/android/android-tester.c b/android/android-tester.c index 09c76c9..12d7613 100644 --- a/android/android-tester.c +++ b/android/android-tester.c @@ -357,8 +357,10 @@ static void emulator(int pipe, int hci_index) ssize_t len; fd = socket(PF_LOCAL, SOCK_DGRAM | SOCK_CLOEXEC, 0); - if (fd < 0) - goto failed; + if (fd < 0) { + close(pipe) + return; + } tv.tv_sec = WAIT_FOR_SIGNAL_TIME; tv.tv_usec = 0; @@ -374,7 +376,6 @@ static void emulator(int pipe, int hci_index) } len = write(pipe, EMULATOR_SIGNAL, sizeof(EMULATOR_SIGNAL)); - if (len != sizeof(EMULATOR_SIGNAL)) goto failed; -- 1.8.3.2