Return-Path: MIME-Version: 1.0 In-Reply-To: <52DE99CA.8030305@gmail.com> References: <5ddfeed2ae259064d50f6b08eb15cf5f.squirrel@mungewell.org> <52DE99CA.8030305@gmail.com> Date: Tue, 21 Jan 2014 17:34:11 +0100 Message-ID: Subject: Re: [PATCH 0/1] HIDP: Add a special case for the Dualshock 4 From: David Herrmann To: Frank Praznik Cc: Simon Wood , Frank Praznik , "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi On Tue, Jan 21, 2014 at 5:01 PM, Frank Praznik wrote: > On 1/21/2014 03:26, David Herrmann wrote: >> >> Hi >> >> On Tue, Jan 21, 2014 at 3:00 AM, wrote: >>>> >>>> This adds a special case in the HIDP core for the Dualshock 4 >>> >>> controller. >>>> >>>> The controller only recognizes output reports with the report type 0x52 >>> >>> and only accepts reports sent via the ctrl channel. >>> >>> Which part of the system is 'at fault' here, is it simply the DS4 >>> behaving >>> incorrectly or that Bluez is not picking up some data or that 'we' are >>> just the incorrect method to send the data (in the hid-sony kernel >>> driver)? >> >> No-one is at fault. Well, strictly speaking the DS4 is, as it has to >> accept SET_REPORT and asynchronous OUTPUT_REPORTs, but it doesn't. >> That's quite common. What we actually want is HIDP to provide to >> functions, one to call SET_REPORT and one to do the async >> OUTPUT_REPORT is currently does. >> >> I implemented this some time ago here: >> http://cgit.freedesktop.org/~dvdhrm/linux/log/?h=hid >> >> Maybe it's time to get that merged. But that hack here is ugly and not >> the way to go. >> >> Thanks >> David > > Believe me, I know that my hack is ugly :). The raw_request functionality > in your repo is exactly what is needed in this scenario. I have the > Bluetooth work on the Sony driver module done, so now it's just a matter of > waiting on if or when this gets merged. My backlog is continuously growing.. it's not the only patch-series I have pending for too long, I'm sincerely sorry. I'm working hard on getting all that stuff out, but note that I will not be able to get this ready before FOSDEM (in 2 weeks). So if you want to pick this up before 3rd of February, I would be more than glad about it. I will review any changes. Otherwise, you'd have to wait for at least 2 more weeks before I can send it out. Also feel free to extract any small part of the series if you don't feel confident about the other stuff. So you can just move the raw_request()/raw_report() into a separate patch. We *definitely* need this callback, so I'd be fine if we add it early. Cheers David