Return-Path: Message-ID: <52CD0FB2.4090507@linux.intel.com> Date: Wed, 08 Jan 2014 10:43:30 +0200 From: Ravi kumar Veeramally MIME-Version: 1.0 To: Szymon Janc CC: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] android-tester: Add HIDHost initial interface setup test References: <1389104291-27210-1-git-send-email-ravikumar.veeramally@linux.intel.com> <1816544.qZJOrILi6u@uw000953> <52CD098D.2090308@linux.intel.com> <3983437.QCzj2PTKjz@uw000953> In-Reply-To: <3983437.QCzj2PTKjz@uw000953> Content-Type: text/plain; charset=UTF-8; format=flowed Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi On 01/08/2014 10:26 AM, Szymon Janc wrote: > Hi Ravi, > >> Hi Szymon, >> >> On 01/08/2014 10:09 AM, Szymon Janc wrote: >>> Hi Ravi, >>> >>>> --- >>>> android/android-tester.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++ >>>> 1 file changed, 46 insertions(+) >>> This patch makes android-tester segfaults when running "HIDHost Init" test. >> When I run output is: >> HIDHost Init - init >> Read Index List callback >> Status: 0x00 >> New hciemu instance created >> Index Added callback >> Index: 0x0001 >> Read Info callback >> Status: 0x00 >> Address: 00:AA:01:00:00:00 >> Version: 0x06 >> Manufacturer: 0x003f >> Supported settings: 0x000002ff >> Current settings: 0x00000080 >> Class: 0x000000 >> Name: >> Short name: >> HIDHost Init - setup >> >> Nothing happened. Let me know what commands and in which sequence it >> occurred ? > This is due to running tester via sudo. Run it from root shell or gdb/valgrind. Yes, got it. I'll send v2. Thanks, Ravi. > >> Regards, >> Ravi. >>>> diff --git a/android/android-tester.c b/android/android-tester.c >>>> index 9a161ad..e4837c6 100644 >>>> --- a/android/android-tester.c >>>> +++ b/android/android-tester.c >>>> @@ -39,6 +39,7 @@ >>>> #include >>>> #include >>>> #include >>>> +#include >>>> >>>> #include "utils.h" >>>> >>>> @@ -79,6 +80,7 @@ struct test_data { >>>> struct hw_device_t *device; >>>> const bt_interface_t *if_bluetooth; >>>> const btsock_interface_t *if_sock; >>>> + const bthh_interface_t *if_hid; >>>> >>>> bool mgmt_settings_set; >>>> bool cb_count_checked; >>>> @@ -958,6 +960,16 @@ static bt_callbacks_t bt_callbacks = { >>>> .le_test_mode_cb = NULL >>>> }; >>>> >>>> +static bthh_callbacks_t bthh_callbacks = { >>>> + .size = sizeof(bthh_callbacks), >>>> + .connection_state_cb = NULL, >>>> + .hid_info_cb = NULL, >>>> + .protocol_mode_cb = NULL, >>>> + .idle_time_cb = NULL, >>>> + .get_report_cb = NULL, >>>> + .virtual_unplug_cb = NULL >>>> +}; >>>> + >>>> static void setup(struct test_data *data) >>>> { >>>> const hw_module_t *module; >>>> @@ -1069,6 +1081,11 @@ static void teardown(const void *test_data) >>>> data->if_bluetooth = NULL; >>>> } >>>> >>>> + if (data->if_hid) { >>>> + data->if_hid->cleanup(); >>>> + data->if_hid = NULL; >>>> + } >>>> + >>>> data->device->close(data->device); >>>> >>>> if (data->bluetoothd_pid) >>>> @@ -1860,6 +1877,32 @@ clean: >>>> close(sock_fd); >>>> } >>>> >>>> +static void setup_hidhost_interface(const void *test_data) >>>> +{ >>>> + struct test_data *data = tester_get_data(); >>>> + bt_status_t status; >>>> + const void *hid; >>>> + >>>> + setup(data); >>>> + >>>> + status = data->if_hid->init(&bthh_callbacks); >>>> + if (status != BT_STATUS_SUCCESS) { >>>> + data->if_hid = NULL; >>>> + tester_setup_failed(); >>>> + return; >>>> + } >>>> + >>>> + hid = data->if_bluetooth->get_profile_interface(BT_PROFILE_HIDHOST_ID); >>>> + if (!hid) { >>>> + tester_setup_failed(); >>>> + return; >>>> + } >>>> + >>>> + data->if_hid = hid; >>>> + >>>> + tester_setup_complete(); >>>> +} >>>> + >>>> #define test_bredrle(name, data, test_setup, test, test_teardown) \ >>>> do { \ >>>> struct test_data *user; \ >>>> @@ -2071,5 +2114,8 @@ int main(int argc, char *argv[]) >>>> setup_socket_interface_enabled, >>>> test_socket_real_connect, teardown); >>>> >>>> + test_bredrle("HIDHost Init", NULL, setup_hidhost_interface, >>>> + test_dummy, teardown); >>>> + >>>> return tester_run(); >>>> } >>>>