Return-Path: MIME-Version: 1.0 In-Reply-To: <1392805549-28152-8-git-send-email-jakub.tyszkowski@tieto.com> References: <1392805549-28152-1-git-send-email-jakub.tyszkowski@tieto.com> <1392805549-28152-8-git-send-email-jakub.tyszkowski@tieto.com> Date: Wed, 19 Feb 2014 07:25:36 -0400 Message-ID: Subject: Re: [RFC 07/11] android/tester: Execute hh connection state cbacks in main loop From: Anderson Lizardo To: Jakub Tyszkowski Cc: BlueZ development Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Jakub, On Wed, Feb 19, 2014 at 6:25 AM, Jakub Tyszkowski wrote: > Execute generic HIDHost connection_state_cb in tester's main loop. > --- > android/android-tester.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/android/android-tester.c b/android/android-tester.c > index 0115943..664f381 100644 > --- a/android/android-tester.c > +++ b/android/android-tester.c > @@ -3212,19 +3212,34 @@ clean: > close(sock_fd); > } > > -static void hidhost_connection_state_cb(bt_bdaddr_t *bd_addr, > - bthh_connection_state_t state) > +static gboolean hidhost_connection_state(gpointer user_data) > { > struct test_data *data = tester_get_data(); > const struct hidhost_generic_data *test = data->test_data; > + struct generic_cb_data *cb_data = user_data; > > data->cb_count++; > > - if (state == BTHH_CONN_STATE_CONNECTED) > + if ((int) cb_data->state == BTHH_CONN_STATE_CONNECTED) You are reusing a variable of different type (bt_state_t vs. bthh_connection_state_t), so I believe it's why you are casting above. My suggestion (if that works) is to declare the state field in generic_cb_data as int, so it should work without any casting. Best Regards, -- Anderson Lizardo http://www.indt.org/?lang=en INdT - Manaus - Brazil