Return-Path: MIME-Version: 1.0 In-Reply-To: <1392714551.5951.275.camel@pohly-mobl1.fritz.box> References: <1392393184-15266-1-git-send-email-luiz.dentz@gmail.com> <1392393184-15266-8-git-send-email-luiz.dentz@gmail.com> <1392714551.5951.275.camel@pohly-mobl1.fritz.box> Date: Tue, 18 Feb 2014 11:30:22 +0200 Message-ID: Subject: Re: [PATCH BlueZ 8/8] doc/obex-api: Update documentation From: Luiz Augusto von Dentz To: Patrick Ohly Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Patrick, On Tue, Feb 18, 2014 at 11:09 AM, Patrick Ohly wrote: > On Fri, 2014-02-14 at 17:53 +0200, Luiz Augusto von Dentz wrote: >> From: Luiz Augusto von Dentz >> >> This adds Suspend and Resume methods and 'suspended' value as status in >> the Transfer interface documentation. >> --- >> doc/obex-api.txt | 18 ++++++++++++++++-- >> 1 file changed, 16 insertions(+), 2 deletions(-) >> >> diff --git a/doc/obex-api.txt b/doc/obex-api.txt >> index 1f22fea..0f57ce1 100644 >> --- a/doc/obex-api.txt >> +++ b/doc/obex-api.txt >> @@ -90,12 +90,26 @@ Methods void Cancel() >> org.bluez.obex.Error.InProgress >> org.bluez.obex.Error.Failed >> >> + void Suspend() >> + >> + Suspend transference. >> + >> + Possible errors: org.bluez.obex.Error.NotAuthorized >> + org.bluez.obex.Error.NotInProgress >> + >> + void Resume() >> + >> + Resume transference. >> + >> + Possible errors: org.bluez.obex.Error.NotAuthorized >> + org.bluez.obex.Error.NotInProgress > ^^^^^^^^^^^^^ > > Should this be a NotSuspended error? Or is it not an error to resume a > transfer which is currently not suspended? Hmm, I would go for InProgress like in Cancel although now that you mentioned we could perhaps ignore such errors if you don't see any value on those. -- Luiz Augusto von Dentz