Return-Path: Date: Tue, 4 Feb 2014 13:55:51 +0200 From: Andrei Emeltchenko To: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH 1/3] avrcp: Avoid unneeded calculation Message-ID: <20140204115549.GM2930@aemeltch-MOBL1> References: <1391098376-26834-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1391098376-26834-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: On Thu, Jan 30, 2014 at 06:12:54PM +0200, Andrei Emeltchenko wrote: > From: Andrei Emeltchenko > > There no need to calculate those values ping > --- > profiles/audio/avrcp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/profiles/audio/avrcp.c b/profiles/audio/avrcp.c > index fa5adab..2e1a940 100644 > --- a/profiles/audio/avrcp.c > +++ b/profiles/audio/avrcp.c > @@ -3177,7 +3177,7 @@ static void avrcp_register_notification(struct avrcp *session, uint8_t event) > pdu->params[0] = event; > pdu->params_len = htons(AVRCP_REGISTER_NOTIFICATION_PARAM_LENGTH); > > - length = AVRCP_HEADER_LENGTH + ntohs(pdu->params_len); > + length = AVRCP_HEADER_LENGTH + AVRCP_REGISTER_NOTIFICATION_PARAM_LENGTH; > > avctp_send_vendordep_req(session->conn, AVC_CTYPE_NOTIFY, > AVC_SUBUNIT_PANEL, buf, length, > @@ -3250,7 +3250,7 @@ static void avrcp_get_capabilities(struct avrcp *session) > pdu->params[0] = CAP_EVENTS_SUPPORTED; > pdu->params_len = htons(AVRCP_GET_CAPABILITIES_PARAM_LENGTH); > > - length = AVRCP_HEADER_LENGTH + ntohs(pdu->params_len); > + length = AVRCP_HEADER_LENGTH + AVRCP_GET_CAPABILITIES_PARAM_LENGTH; > > avctp_send_vendordep_req(session->conn, AVC_CTYPE_STATUS, > AVC_SUBUNIT_PANEL, buf, length, > -- > 1.8.3.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html