Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1874\)) Subject: Re: [PATCH 09/11] bluetooth: hci_ldisc: fix deadlock condition From: Marcel Holtmann In-Reply-To: <1395343807-21618-9-git-send-email-balbi@ti.com> Date: Thu, 20 Mar 2014 12:40:40 -0700 Cc: Greg KH , linux-serial@vger.kernel.org, linux-bluetooth@vger.kernel.org, Peter Hurley , m-karicheri2@ti.com, b32955@freescale.com, Linux OMAP Mailing List , Linux Kernel Mailing List Message-Id: <95DFF994-1668-4F93-943B-06805FD5B20B@holtmann.org> References: <1395343807-21618-1-git-send-email-balbi@ti.com> <1395343807-21618-9-git-send-email-balbi@ti.com> To: Felipe Balbi Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Felipe, > LDISCs shouldn't call tty->ops->write() from within > ->write_wakeup(). > > ->write_wakeup() is called with port lock taken and > IRQs disabled, tty->ops->write() will try to acquire > the same port lock and we will deadlock. > > Reviewed-by: Peter Hurley > Reported-by: Huang Shijie > Signed-off-by: Felipe Balbi > --- > drivers/bluetooth/hci_ldisc.c | 24 +++++++++++++++++++----- > drivers/bluetooth/hci_uart.h | 1 + > 2 files changed, 20 insertions(+), 5 deletions(-) I hope these are not causing any conflicts with bluetooth-next / linux-next. If not, then I can let Greg take it through tty-next tree. Acked-by: Marcel Holtmann Regards Marcel