Return-Path: Message-ID: <53209B18.5000003@linux.intel.com> Date: Wed, 12 Mar 2014 19:36:24 +0200 From: Ravi kumar Veeramally MIME-Version: 1.0 To: Andrzej Kaczmarek CC: linux-bluetooth Subject: Re: [PATCH 06/15] android/hal-msg: Add HDP app channel state event struct References: <1394637058-586-1-git-send-email-ravikumar.veeramally@linux.intel.com> <1394637058-586-7-git-send-email-ravikumar.veeramally@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, On 03/12/2014 05:57 PM, Andrzej Kaczmarek wrote: > Hi Ravi, > > On 12 March 2014 16:10, Ravi kumar Veeramally > wrote: >> --- >> android/hal-msg.h | 16 ++++++++++++++++ >> 1 file changed, 16 insertions(+) >> >> diff --git a/android/hal-msg.h b/android/hal-msg.h >> index 694529f..0139543 100644 >> --- a/android/hal-msg.h >> +++ b/android/hal-msg.h >> @@ -1001,12 +1001,28 @@ struct hal_ev_pan_conn_state { >> #define HAL_HEALTH_APP_DEREG_SUCCESS 0x02 >> #define HAL_HEALTH_APP_DEREG_FAILED 0x03 >> >> +#define HAL_HEALTH_CHANL_STATE_CONNECTING 0x00 >> +#define HAL_HEALTH_CHANL_STATE_CONNECTED 0x01 >> +#define HAL_HEALTH_CHANL_STATE_DISCONNECTING 0x02 >> +#define HAL_HEALTH_CHANL_STATE_DISCONNECTED 0x03 >> +#define HAL_HEALTH_CHANL_STATE_DESTROYED 0x04 >> + >> #define HAL_EV_HEALTH_APP_REG_STATE 0x81 >> struct hal_ev_health_app_reg_state { >> uint16_t id; >> uint8_t state; >> } __attribute__((packed)); >> >> +#define HAL_EV_HEALTH_CHNL_STATE 0x82 > You have CHNL here and CHANL in states definitions - better have them > consistent. I guess either CHAN or CHANNEL would be actually better. Ok, I will fix. >> +struct hal_ev_health_chnl_state { >> + uint16_t app_id; >> + uint8_t bdaddr[6]; >> + uint8_t mdep_index; >> + uint16_t chnl_id; >> + uint8_t chnl_state; > Same here - chan or channel. > >> + uint32_t file_descr; > fd shall be passed as auxiliary data - there's parameter for this in > IPC calls. Now you just pass plain int value which is useless as fd. OK. Thanks, Ravi.