Return-Path: From: Lukasz Rymanowski To: linux-bluetooth@vger.kernel.org Cc: szymon.janc@tieto.com, johan.hedberg@gmail.com, Jakub Tyszkowski Subject: [PATCH v4 02/38] android/gatt: Remove redundant find function parameter Date: Wed, 30 Apr 2014 11:13:33 +0200 Message-Id: <1398849249-5868-3-git-send-email-lukasz.rymanowski@tieto.com> In-Reply-To: <1398849249-5868-1-git-send-email-lukasz.rymanowski@tieto.com> References: <1398849249-5868-1-git-send-email-lukasz.rymanowski@tieto.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: From: Jakub Tyszkowski As client and server apps id is guaranteed to be unique, there is no need for this search function parameter. --- android/gatt.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/android/gatt.c b/android/gatt.c index f9eff30..0bb5a70 100644 --- a/android/gatt.c +++ b/android/gatt.c @@ -1248,8 +1248,7 @@ static void handle_client_unregister(const void *buf, uint16_t len) HAL_OP_GATT_CLIENT_UNREGISTER, status); } -static struct app_connection *find_conn(const bdaddr_t *addr, int32_t app_id, - int32_t app_type) +static struct app_connection *find_conn(const bdaddr_t *addr, int32_t app_id) { struct app_connection conn_match; struct gatt_device *dev = NULL; @@ -2891,7 +2890,7 @@ static void handle_client_register_for_notification(const void *buf, android2bdaddr(&cmd->bdaddr, &addr); - conn = find_conn(&addr, cmd->client_if, APP_CLIENT); + conn = find_conn(&addr, cmd->client_if); if (!conn) { status = HAL_STATUS_FAILED; goto failed; @@ -2997,7 +2996,7 @@ static void handle_client_deregister_for_notification(const void *buf, android2bdaddr(&cmd->bdaddr, &addr); - conn = find_conn(&addr, cmd->client_if, APP_CLIENT); + conn = find_conn(&addr, cmd->client_if); if (!conn) { status = HAL_STATUS_FAILED; goto failed; -- 1.8.4