Return-Path: From: Andrei Emeltchenko To: linux-bluetooth@vger.kernel.org Subject: [PATCH 1/7] android/handsfree: Check service class is not zero Date: Thu, 17 Apr 2014 15:23:45 +0300 Message-Id: <1397737431-6101-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: From: Andrei Emeltchenko Fixes static analyzers NULL dereference warnings. The similar check is done in src/device.c in line 2959. --- android/handsfree.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/android/handsfree.c b/android/handsfree.c index 02b6dad..c8026a0 100644 --- a/android/handsfree.c +++ b/android/handsfree.c @@ -1405,6 +1405,9 @@ static void sdp_hsp_search_cb(sdp_list_t *recs, int err, gpointer data) goto fail; } + if (!classes) + goto fail; + if (sdp_get_access_protos(recs->data, &protos) < 0) { error("handsfree: unable to get access protocols from record"); sdp_list_free(classes, free); @@ -1495,6 +1498,9 @@ static void sdp_hfp_search_cb(sdp_list_t *recs, int err, gpointer data) goto fail; } + if (!classes) + goto fail; + if (sdp_get_access_protos(recs->data, &protos) < 0) { error("handsfree: unable to get access protocols from record"); sdp_list_free(classes, free); -- 1.8.3.2