Return-Path: Date: Fri, 30 May 2014 13:28:01 +0300 From: Johan Hedberg To: Lukasz Rymanowski Cc: linux-bluetooth@vger.kernel.org, szymon.janc@tieto.com Subject: Re: [PATCH v2 00/10] Fixes to sign write Message-ID: <20140530102801.GA3761@t440s.P-661HNU-F1> References: <1401371384-10427-1-git-send-email-lukasz.rymanowski@tieto.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1401371384-10427-1-git-send-email-lukasz.rymanowski@tieto.com> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Lukasz, On Thu, May 29, 2014, Lukasz Rymanowski wrote: > This patch set brings couple of bug fixes founded during tests against PTS. > Biggest change is that I had to move signing procedure down to att.c as > not only payload need to be signed but also opcode and handle. > Therefore it makes sense to generate signature in place where pdu is encoded > > With those patches PTS TC_GAW_CL_BV_02_C and TC_GAW_SR_BV_02_C are passing > > v2: > * Rebase > * Added one more cleanup patch to the series (remove not needed mempcy) > > Lukasz Rymanowski (10): > android/gatt: Verify signature counter from remote > android/gatt: Fix handling signed write command from remote > android/gatt: Fix signed write command encoding > shared/crypto: Fix concatenate of sign counter into the msg > shared/crypto: Fix byte order of sign counter added to signature > shared/crypto: Change swap128 to swap_buf > shared/crypto: Fix byte order of message > unit/crypto: Update unit test vectors after changes in singing process > android/pts: Update GATT PTS test results > shared/crypto: Remove not needed memcpy > > Makefile.am | 3 ++- > Makefile.tools | 4 +++- > android/gatt.c | 25 ++++++++++++------------- > android/pts-gatt.txt | 20 ++++++++++++++++++-- > attrib/att.c | 11 +++++++---- > attrib/att.h | 6 +++++- > attrib/gatt.c | 11 ++++++++--- > attrib/gatt.h | 4 +++- > src/shared/crypto.c | 27 +++++++++++++++------------ > unit/test-crypto.c | 6 +++--- > 10 files changed, 76 insertions(+), 41 deletions(-) All patches in this set have been applied. Thanks. Johan