Return-Path: From: Szymon Janc To: Marcel Holtmann Cc: Szymon Janc , linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] android: Build btiotest tool Date: Mon, 16 Jun 2014 22:25:52 +0200 Message-ID: <1900079.HqpV8RXPni@athlon> In-Reply-To: References: <1402927795-14834-1-git-send-email-szymon.janc@tieto.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" List-ID: Hi Marcel, On Monday 16 June 2014 18:27:27 Marcel Holtmann wrote: > Hi Szymon, > > > This is useful for testing. > > --- > > android/Android.mk | 32 ++++++++++++++++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > diff --git a/android/Android.mk b/android/Android.mk > > index fc7b59d..ecff9c8 100644 > > --- a/android/Android.mk > > +++ b/android/Android.mk > > @@ -620,3 +620,35 @@ LOCAL_MODULE := avinfo > > LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac > > > > include $(BUILD_EXECUTABLE) > > + > > +# > > +# btiotest > > +# > > + > > +include $(CLEAR_VARS) > > + > > +LOCAL_SRC_FILES := \ > > + bluez/tools/btiotest.c \ > > + bluez/btio/btio.c \ > > + bluez/lib/bluetooth.c \ > > I would actually prefer that we get rid of btio and integrated this in > struct io properly. However what can be tested with btiotest that can not > be tested with l2test and other tools. This is mostly for tests related to (updating) connection security level. We should be able to craft custom GATT HAL test command for that, although this is not really related to GATT... -- Szymon K. Janc szymon.janc@gmail.com