Return-Path: <cyrus@holtmann.org>
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\))
Subject: Re: [PATCH] android: Build btiotest tool
From: Marcel Holtmann <marcel@holtmann.org>
In-Reply-To: <1402927795-14834-1-git-send-email-szymon.janc@tieto.com>
Date: Mon, 16 Jun 2014 18:27:27 +0200
Cc: linux-bluetooth@vger.kernel.org
Message-Id: <DC8DF41D-0449-41E5-B8D6-7D8D866BC9B1@holtmann.org>
References: <1402927795-14834-1-git-send-email-szymon.janc@tieto.com>
To: Szymon Janc <szymon.janc@tieto.com>
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Szymon,

> This is useful for testing.
> ---
> android/Android.mk | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
> 
> diff --git a/android/Android.mk b/android/Android.mk
> index fc7b59d..ecff9c8 100644
> --- a/android/Android.mk
> +++ b/android/Android.mk
> @@ -620,3 +620,35 @@ LOCAL_MODULE := avinfo
> LOCAL_ADDITIONAL_DEPENDENCIES := $(LOCAL_PATH)/bluez/configure.ac
> 
> include $(BUILD_EXECUTABLE)
> +
> +#
> +# btiotest
> +#
> +
> +include $(CLEAR_VARS)
> +
> +LOCAL_SRC_FILES := \
> +	bluez/tools/btiotest.c \
> +	bluez/btio/btio.c \
> +	bluez/lib/bluetooth.c \

I would actually prefer that we get rid of btio and integrated this in struct io properly. However what can be tested with btiotest that can not be tested with l2test and other tools.

Regards

Marcel