Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH BlueZ v2 00/13] Introduce shared/gatt-client From: Marcel Holtmann In-Reply-To: <1409261125-6673-1-git-send-email-armansito@chromium.org> Date: Thu, 28 Aug 2014 14:39:08 -0700 Cc: linux-bluetooth@vger.kernel.org Message-Id: <3461916D-5CED-43F4-86D7-22084E3E1195@holtmann.org> References: <1409261125-6673-1-git-send-email-armansito@chromium.org> To: Arman Uguray Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Arman, > * v2: > - Rebased on top of master > - Fixed empty line at the end of file. > - Other minor style fixes > > * v1: > - Moved the TODOs to the top-level TODO file in a new ATT/GATT section. > - Removed bt_gatt_client_init. Instead, added a > bt_gatt_client_set_ready_handler to set up a handler which gets called when > discovery is over. Discovery is initiated in bt_gatt_client_new instead. > - Removed bt_gatt_client_get_att. > - Removed the (un)register_service_changed functions for now. > - Removed bt_gatt_client_destroy in favor of ref/unref functions. > - Dropped "_handler" from bt_att_(un)register_disconnect_handler functions. > > Arman Uguray (13): > TODO: Add items for tasks involving the new shared ATT/GATT stack > shared/gatt-helpers: Remove service, characteristic, descriptor > structures. > shared/gatt-helpers: Added result count functions. > shared/gatt-client: Added initial skeleton and simple functions. > shared/att: Support multiple disconnect handlers. > shared/att: Add BT_ATT_DEFAULT_LE_MTU macro. > shared/gatt-helpers: Fixed typo in callback args. > shared/gatt-client: Add bt_gatt_client_set_debug. > shared/gatt-client: Implement initial service discovery. > shared/gatt-client: Add service iterator functions. > shared/gatt-client: Implement characteristic discovery. > shared/gatt-client: Implement descriptor discovery. > TODO: shared/gatt-client has been defined and discovery implemented > > Makefile.am | 3 +- > TODO | 90 ++++++- > src/shared/att-types.h | 2 + > src/shared/att.c | 161 ++++++++++-- > src/shared/att.h | 11 +- > src/shared/gatt-client.c | 652 ++++++++++++++++++++++++++++++++++++++++++++++ > src/shared/gatt-client.h | 89 +++++++ > src/shared/gatt-helpers.c | 100 +++++-- > src/shared/gatt-helpers.h | 36 +-- > 9 files changed, 1063 insertions(+), 81 deletions(-) > create mode 100644 src/shared/gatt-client.c > create mode 100644 src/shared/gatt-client.h all 13 patches have been applied. Regards Marcel