Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [A2DP] Incoming connections do not succeed From: Marcel Holtmann In-Reply-To: Date: Thu, 28 Aug 2014 13:37:36 -0700 Cc: Artem Rakhov , "linux-bluetooth@vger.kernel.org" Message-Id: <3A920A25-DC84-44B7-AE04-E41669133DE1@holtmann.org> References:

<574DE1E1-7A53-4629-88FC-7164EC1880AA@holtmann.org>

<2EF4B6C6-2375-45B7-B1AF-D30C4799AC93@holtmann.org> <2854D296-3CCA-4628-90B5-76D03EF2660D@holtmann.org> <3775CFA8-F840-440C-AC0E-FC639F542AA6@holtmann.org>

<3F6C8060-4B6F-4F18-A0D1-15B6CD7CE512@holtmann.org>

To: Luiz Augusto von Dentz Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Luiz, >>>>>>> please do not top post on this mailing list. It does break the reading thread. >>>>>>> >>>>>>>> Here is hcitool info: >>>>>>>> >>>>>>>> BD Address: 10:B7:F6:01:31:ED >>>>>>>> Device Name: Monster Clarity >>>>>>>> LMP Version: 2.1 (0x4) LMP Subversion: 0x189c >>>>>>>> Manufacturer: Cambridge Silicon Radio (10) >>>>>>>> Features page 0: 0x01 0x00 0x00 0x00 0x00 0x00 0x00 0x00 >>>>>>>> <3-slot packets> >>>>>>>> Features page 1: 0xff 0xff 0x8f 0xfe 0x9b 0xff 0x59 0x83 >>>>>>>> >>>>>>>> Label also says Precision Micro Bluetooth Speaker 100. >>>>>>> >>>>>>> normally all CSR based solutions should just work. Maybe this is just a bad firmware. Are you sure that Connection Pending is really causing the observed problem. It sounds strange to hit that on a CSR based speaker. >>>>>> >>>>>> I compared the logs from avtest and bluetoothd (attached earlier in >>>>>> this thread). I think the only difference that could matter is this >>>>>> Authorization Pending response. >>>>> >>>>> I've tested several devices with and without Defer Setup feature enabled. >>>>> >>>>> Here is a list of devices, which successfully initiate A2DP >>>>> connection, not depending on Defer Setup: >>>>> Creative WP-350 Headset >>>>> MiiKey Rythm >>>>> JBL Micro Wireless >>>>> HMDX Rave >>>>> Plantronics BBfit >>>>> Bose SoundLink Mobile speaker II >>>>> SOL Tracks Air >>>>> Sony MDR-1RBT >>>>> >>>>> Here is a list of devices, which fail to initiate A2DP connection with >>>>> Defer Setup enabled, but work fine when Defer Setup is disabled: >>>>> Monster Clarity HD >>>>> Motorola S9-HD >>>>> Sennheiser PX210 >>>>> 2010 Toyota Prius >>>> >>>> are all of these CSR based devices? If so then it sounds like a batch of broken CSR firmware. If not, then the L2CAP test cases might better be extended to have a test case for this. It is dangerous if such a fundamental Bluetooth 1.1 feature is not working correctly. >>> >>> Yes, all these devices are CSR-based. >> >> Well I have access to none of those which is kind nice. >> >>>>> There are no devices, which are working with Defer Setup, and not >>>>> working without Defer Setup. So I didn't see any regression. >>>>> >>>>> As a result, 4 out of 12 devices do not connect as expected with Defer >>>>> Setup enabled. I think we should consider disabling Defer Setup by >>>>> default, at least for audio. >>>> >>>> I all cases this is the A2DP signaling channel that causes the problem? It is not the media channel that is required for streaming? >>> >>> Yes, exactly same scenario. The very first connection fails from >>> speaker to source, which goes to AVDTP (PSM 25). >> >> There are some other things to experiment, there seems to be possible >> to use ERTM nowadays, for signalling only, and while this does not >> exactly change in any way how we use authorization pending response it >> perhaps make a difference in terms of timing, if we are lucky, >> otherwise we can go with whitelist and retry. >> >>>> Our real problem is that we need Defer Setup to be able to cleanly reject connections from devices that we do not know and do not want to talk to use. Especially if they are just not authorized to do so. >>>> >>>> Maybe we should use the proposal that Luiz had and just disconnect after a timeout and try to establish the connection from our side. That might actually be useful as a workaround. An alternative option is that we delay the connection pending message for some time and give userspace the chance to respond with either read() or close(). That way we would send the correct answer. However that timeout can only be really short since we need to keep the L2CAP signaling working correctly. So it would only work for cases where the daemon has all information to make a decision. If it asks the user, then this is off limits. >>>> >>>> That said, Linux 3.17 is allowing us to use a whitelist for BR/EDR that might be useful to mitigate this behavior as well. Unknown devices would be blocked on the ACL level already. >> >> If whitelist for classic is to be based on the trusted list, which I >> assume it should be, then the kernel could accept the connection right >> away but then we need some mechanism to query if the whitelist has >> taken effect or maybe it is fine already since bt_io_accept does the >> following: >> >> if (!(pfd.revents & POLLOUT)) { >> if (read(sock, &c, 1) < 0) { >> ERROR_FAILED(err, "read", errno); >> return FALSE; >> } >> } >> >> So POLLOUT seems to be for checking if the socket has been accepted >> already, in case we have a older kernel we can only retry if >> authorization succeeds but that will probably only happen if the >> device happens to be trusted otherwise it will trigger the agent for >> user to authorize and it more likely the device will disconnect before >> the user can react cancelling the authorization. > > I was checking how whitelist actually works currently and in fact it > is not based on trusted list but on persistency, but we could use > action 2 for BREDR once they are marked as trusted but perhaps you > guys had something else in mind while designing Add Device command. If > we can't really reuse action 2, or have a dedicated action for trusted > devices, then Im afraid it won't help in this specific problem. the action 0x02 is not defined or implemented for BR/EDR devices. Regards Marcel