Return-Path: Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.6\)) Subject: Re: [PATCH] bluetooth/dtl1_cs: Remove typedefs nsh_t and dtl1_info_t From: Marcel Holtmann In-Reply-To: <20140813092227.GA3221@himangi-Dell> Date: Wed, 13 Aug 2014 10:18:07 -0700 Cc: "Gustavo F. Padovan" , Johan Hedberg , linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, Julia Lawall Message-Id: References: <20140813092227.GA3221@himangi-Dell> To: Himangi Saraogi Sender: linux-kernel-owner@vger.kernel.org List-ID: Hi Himangi, > The Linux kernel coding style guidelines suggest not using typedefs > for structure types. This patch gets rid of the typedefs for nsh_t and > dtl1_info_t. Also, the name of the struct is changed to drop the _t, > to make the name look less typedef-like. > > The following Coccinelle semantic patch detects the case for dtl1_info_t > and a similar patch finds the nsh_t case: > > @tn@ > identifier i; > type td; > @@ > > -typedef > struct i { ... } > -td > ; > > @@ > type tn.td; > identifier tn.i; > @@ > > -td > + struct i > > Signed-off-by: Himangi Saraogi > Acked-by: Julia Lawall > --- > drivers/bluetooth/dtl1_cs.c | 36 ++++++++++++++++++------------------ > 1 file changed, 18 insertions(+), 18 deletions(-) patch has been applied to bluetooth-next tree. Regards Marcel