Return-Path: MIME-Version: 1.0 In-Reply-To: <1410441607-9687-2-git-send-email-gowtham.ab@samsung.com> References: <1410441607-9687-1-git-send-email-gowtham.ab@samsung.com> <1410441607-9687-2-git-send-email-gowtham.ab@samsung.com> Date: Fri, 12 Sep 2014 00:00:04 +0300 Message-ID: Subject: Re: [PATCH 2/7] obexd/client/map : Handle MAP ReadStatusChanged event type From: Luiz Augusto von Dentz To: Gowtham Anandha Babu Cc: "linux-bluetooth@vger.kernel.org" , Dmitry Kasatkin , Bharat Panda , cpgs@samsung.com Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, On Thu, Sep 11, 2014 at 4:20 PM, Gowtham Anandha Babu wrote: > Adds ReadStatusChanged MCE event type handling in map_handle_notification() > --- > obexd/client/map.c | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/obexd/client/map.c b/obexd/client/map.c > index 520e492..a505707 100644 > --- a/obexd/client/map.c > +++ b/obexd/client/map.c > @@ -1872,6 +1872,25 @@ static void map_handle_status_changed(struct map_data *map, > "Status"); > } > > +static void map_handle_read_status_changed(struct map_data *map, > + struct map_event *event) > +{ > + struct map_msg *msg; > + > + msg = g_hash_table_lookup(map->messages, &event->handle); > + if (msg == NULL) > + return; > + > + /* In MAP V 1.2 specification : ReadStatusChanged event didn't have clear explaination. > + So as of now it will set the message read status as "yes" if it was "no" already > + and the other way round. This implementation may change once we get 'read' attribute in the event report. */ The coding style for multi-line comment is wrong, please check our coding style there is a specific chapter for it, and to be honest I did not get it why we are toggling the value if it is not clearly explained, btw there is a typo there, perhaps you should check against the test specification if there is any test regarding that or any errata documenting the behavior. > + if(msg->flags & MAP_MSG_FLAG_READ) > + parse_read(msg,"no"); > + else > + parse_read(msg,"yes"); > +} > + > static void map_handle_folder_changed(struct map_data *map, > struct map_event *event, > const char *folder) > @@ -1927,6 +1946,9 @@ static void map_handle_notification(struct map_event *event, void *user_data) > case MAP_ET_MESSAGE_SHIFT: > map_handle_folder_changed(map, event, event->folder); > break; > + case MAP_ET_READ_STATUS_CHANGED: > + map_handle_read_status_changed(map, event); > + break; > default: > break; > } > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Luiz Augusto von Dentz