Return-Path: <cyrus@holtmann.org>
MIME-Version: 1.0
In-Reply-To: <000601cfcda9$86b83520$94289f60$@samsung.com>
References: <1410352944-16586-1-git-send-email-gowtham.ab@samsung.com>
	<3030038.LEiDkyyyur@uw000953>
	<000601cfcda9$86b83520$94289f60$@samsung.com>
Date: Thu, 11 Sep 2014 14:33:31 +0300
Message-ID: <CABBYNZJw5Hsbn_Dn77UeBmOafFeLeZ-uMejJS7uWiM+c3oBPQg@mail.gmail.com>
Subject: Re: [PATCH 3/3] android/hal-utils.c : Fix null pointer dereference
From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Gowtham Anandha Babu <gowtham.ab@samsung.com>
Cc: Szymon Janc <szymon.janc@tieto.com>,
	"linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>,
	Dmitry Kasatkin <d.kasatkin@samsung.com>,
	Bharat Panda <bharat.panda@samsung.com>, cpgs@samsung.com
Content-Type: text/plain; charset=UTF-8
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi,

On Thu, Sep 11, 2014 at 1:16 PM, Gowtham Anandha Babu
<gowtham.ab@samsung.com> wrote:
> Hi,
>
>> -----Original Message-----
>> From: Szymon Janc [mailto:szymon.janc@tieto.com]
>> Sent: Thursday, September 11, 2014 3:11 PM
>> To: gowtham babu
>> Cc: linux-bluetooth@vger.kernel.org; d.kasatkin@samsung.com;
>> bharat.panda@samsung.com; cpgs@samsung.com
>> Subject: Re: [PATCH 3/3] android/hal-utils.c : Fix null pointer dereference
>>
>> Hi,
>>
>> On Wednesday 10 of September 2014 18:12:24 gowtham babu wrote:
>> > Handles the possible null pointer dereference: bd_addr by checking it
>> against null.
>> > ---
>> >  android/hal-utils.c | 4 +++-
>> >  1 file changed, 3 insertions(+), 1 deletion(-)
>> >
>> > diff --git a/android/hal-utils.c b/android/hal-utils.c index
>> > ceefefc..64ab5a1 100644
>> > --- a/android/hal-utils.c
>> > +++ b/android/hal-utils.c
>> > @@ -166,11 +166,13 @@ int int2str_findstr(const char *str, const struct
>> int2str m[])
>> >   */
>> >  const char *bt_bdaddr_t2str(const bt_bdaddr_t *bd_addr, char *buf)  {
>> > -   const uint8_t *p = bd_addr->address;
>> > +   const uint8_t *p;
>> >
>> >     if (!bd_addr)
>> >             return strcpy(buf, "NULL");
>> >
>> > +   p = bd_addr->address;
>> > +
>> >     snprintf(buf, MAX_ADDR_STR_LEN,
>> "%02x:%02x:%02x:%02x:%02x:%02x",
>> >                                     p[0], p[1], p[2], p[3], p[4], p[5]);
>> >
>>
>> This patch looks OK to me, but I have one question before applying it.
>>
>> Do you really want your name to be visible in git history as it is in this email ie.
>> without any capital letters?
>>
>> --
>> Best regards,
>> Szymon Janc
>
>
> Sorry for the top posting. Regarding the git name, that’s  OK.

Just be consistent, in this one you actually are using capital letter
and a middle name.


-- 
Luiz Augusto von Dentz