Return-Path: Date: Mon, 8 Sep 2014 20:36:54 +0200 From: Alexander Aring To: Martin Townsend Cc: Marcel Holtmann , linux-zigbee-devel@lists.sourceforge.net, linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org Subject: Re: [PATCH v2 bluetooth-next] Simplify lowpan receive path so skb is freed in lowpan_rcv when dropped. Message-ID: <20140908183652.GA633@omega> References: <53DCE75C.2030305@xsilon.com> <20140821083945.GA29484@omega> <3DF0C18C-4A97-4A00-AB0F-9E01F72CE967@holtmann.org> <53FE446D.6040805@xsilon.com> <20140908104008.GB6981@omega> <540DF1AE.2070709@xsilon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <540DF1AE.2070709@xsilon.com> List-ID: Hi Martin, On Mon, Sep 08, 2014 at 07:13:02PM +0100, Martin Townsend wrote: ... > >>Hi, > >> > >>I'll respin and include the memory leak fix and this patch and a couple of > >>others I have and send as a series to bluetooth. What bluetooth git > >>repository should I base the series on? > >> > >What's the state about to fix this bad issue? :-) > > > >I didn't saw any new patches because of this. > > > >- Alex > >-- > >To unsubscribe from this list: send the line "unsubscribe linux-wpan" in > >the body of a message to majordomo@vger.kernel.org > >More majordomo info at http://vger.kernel.org/majordomo-info.html > > Sorry for the delay, been on hols for a few days, I will create the patches > tomorrow if I get time. > > I have also implemented Generic Header Compression[0] which is still in > draft at the moment but I can't imagine it will change much before being > released. I'm going to integrate it into our linux repository this week. > Would you be interested in putting it in linux-wpan or linux-wpan-next or > would you prefer to wait until it gets it RFC status? > no, for me it's okay to have this mainline. I heard that a draft becomes no RFC when nobody implements it. But another point, I want to avoid that everything is putted into the iphc file for next header compression. Did you saw the patches for the next header compression layer? This is a layer to separate next header implementation, like IPv6 it does for next header [0]. [0] shows the registration of the next header protocols. We should have something similar and I post some months a RFC about that. I got some review notes and need to rework it, working branch is at [1]. Also I added that we drop packets for IPv6 Header Extensions, described at [2]. We currently no support this kind of next header compression and if we don't check on it, we send garbage to IPv6 layer. (That's of course one more argument to implement draft next header compression formats). For now, we should make it like this: - First you send patches for the fixes. - Then I will send patches for the nhc layer. - You send patches to adding the your next header compression formats. based on the nhc layer. Is that okay for you? It should easily for you to add your header compression formats. (Filling some struct with macro and implement some callbacks). This is all related stuff to the GENERIC 6LOWPAN branch, all which belongs to IPHC and IPHC contains next header compression. As conclusion this should be go to bluetooth/bluetooth-next. Bug fixes to bluetooth, new features to bluetooth-next. btw: I working on the 802.15.4 rework. I am sure you know that I want to make a rework of the 802.15.4 stack. Very busy at the moment, but this should not affect the net/6lowpan branch. Only the net/ieee802.15.4/6lowpan. I will take some time, so after you send fixes for this I will rebase/rework the nhc layer patches to try to bring it mainline. Then you can make your work on it. - Alex [0] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/net/ipv6/af_inet6.c?id=refs/tags/v3.17-rc4#n822 [1] https://github.com/linux-wpan/linux-wpan-next/tree/nhc_layer [2] http://tools.ietf.org/html/rfc6282#section-4.2