Return-Path: MIME-Version: 1.0 In-Reply-To: <000601cfc84b$d131d4c0$73957e40$@samsung.com> References: <1409204803-3705-1-git-send-email-gowtham.ab@samsung.com> <000001cfc2a0$0032aa30$0097fe90$@samsung.com> <000601cfc84b$d131d4c0$73957e40$@samsung.com> Date: Thu, 4 Sep 2014 17:42:56 +0300 Message-ID: Subject: Re: [MAP] obexd/client: Handle MAP event types From: Luiz Augusto von Dentz To: Gowtham Anandha Babu Cc: "linux-bluetooth@vger.kernel.org" , Bharat Panda , p.sinha@samsung.com, Dmitry Kasatkin Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi, On Thu, Sep 4, 2014 at 5:22 PM, Gowtham Anandha Babu wrote: > Hi, > >> -----Original Message----- >> From: Gowtham Anandha Babu [mailto:gowtham.ab@samsung.com] >> Sent: Thursday, August 28, 2014 7:03 PM >> To: 'Luiz Augusto von Dentz' >> Cc: 'linux-bluetooth@vger.kernel.org' >> Subject: RE: [MAP] obexd/client: Handle MAP event types >> >> Hi Luiz, >> >> > -----Original Message----- >> > From: Luiz Augusto von Dentz [mailto:luiz.dentz@gmail.com] >> > Sent: Thursday, August 28, 2014 3:16 PM >> > To: Gowtham Anandha Babu >> > Cc: linux-bluetooth@vger.kernel.org >> > Subject: Re: [MAP] obexd/client: Handle MAP event types >> > >> > Hi, >> > >> > On Thu, Aug 28, 2014 at 12:11 PM, Gowtham Anandha Babu >> > wrote: >> > > Hi Luiz, >> > > But in the obexd/client/mns.c >> > > Inside parse_event_report_type() function, event types are >> > > assigned >> > with the values MAP_ET_MEMORY_FULL and >> MAP_ET_MEMORY_AVAILABLE. >> > > It should be handled in the map_handle_notification() inside map.c. >> > >> > Please do not top post in the mailing list, use inline posting. >> > Regarding the parsing, yes it does have proper handling of those event >> > but there is no mapping to the D-Bus API therefore we ignore those >> > memory event. As I mentioned the they are not per message so they >> > cannot be set as a status of a message, anyway it would not make >> > sense, and having it on the MessageAccess interface has not been >> > considered but first I need to have a proper user case where it makes >> sense to expose those events. >> > >> > Luiz Augusto von Dentz >> >> >> The use cases are: >> 1) What if one tries to push a message, but the space available in the MSE >> device is not enough. So MCE will receive Memory Full Event. >> 2) Once the user cleared some memory in the MSE device, MCE should be >> notified with Memory Available Event. >> As you mentioned earlier, these cannot be set as a status of a message. But >> MCE device needs to be get notified about this events. >> >> If the MCE receives Memory Full event, it will set the status as "delivery- >> failure". >> Once MSE device(server) deletes some messages and send Memory >> Available event then MCE will push the pending message. >> Can it be done like this? >> >> Regards, >> Gowtham > > Just a reminder. With little bit clarity , If MCE pushes the message, the "Memory Full" event type is given by MSE. Then I think the status of that message will be empty. Instead we can set the status as a "sending-failure". > Whatever explained I added in the attached patch for your kind perusal. Im afraid this would not work because the event handle is not set it will fail trying to find the message object, it really needs to be a property of the session to be propagated. -- Luiz Augusto von Dentz