Return-Path: MIME-Version: 1.0 In-Reply-To: <6112AC01-B1C4-4DF8-8085-63334761D725@holtmann.org> References: <132658595.194181413985732727.JavaMail.weblogic@epmlwas01a> <6112AC01-B1C4-4DF8-8085-63334761D725@holtmann.org> Date: Fri, 31 Oct 2014 16:03:08 +0900 Message-ID: Subject: Re: [RFC] Bluetooth : Fix hci_sync miss wakeup interrupt From: "Chanyeol,Park" To: Marcel Holtmann Cc: linux-bluetooth@vger.kernel.org, =?UTF-8?B?67CV7LCs7Je0?= Content-Type: multipart/alternative; boundary=bcaec51a77c8dab9b60506b296b0 List-ID: --bcaec51a77c8dab9b60506b296b0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Hi Marcel Due to internal reason I made mistake. I raised it again. Thanks Chanyeol 2014. 10. 29. =EC=98=A4=EC=A0=84 2:32=EC=97=90 "Marcel Holtmann" =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > Hi Chan-yeol, > > > __hci_cmd_sync_ev(), __hci_req_sync() could miss wake_up_interrupt from > > hci_req_sync_complete() because hci_cmd_work() workquee and its reponse > > could be completed before they are ready to get the signal through > > add_wait_queue(), set_current_state(TASK_INTERRUPTIBLE). > > > > Signed-off-by: Chan-yeol Park > > Signed-off-by: Kyungmin Park > > --- > > net/bluetooth/hci_core.c | 18 +++++++++++------- > > 1 file changed, 11 insertions(+), 7 deletions(-) > > > > diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c > > index cb05d7f..c008f1f 100644 > > --- a/net/bluetooth/hci_core.c > > +++ b/net/bluetooth/hci_core.c > > @@ -1147,13 +1147,15 @@ struct sk_buff *__hci_cmd_sync_ev(struct hci_de= v > *hdev, u16 opcode, u32 plen, > > > > hdev->req_status =3D HCI_REQ_PEND; > > > > - err =3D hci_req_run(&req, hci_req_sync_complete); > > - if (err < 0) > > - return ERR_PTR(err); > > - > > the whole patch has whitespace damages. Please fix this. > > Regards > > Marcel > > -- > To unsubscribe from this list: send the line "unsubscribe linux-bluetooth= " > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > --bcaec51a77c8dab9b60506b296b0 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Marcel

Due to internal reason I made mistake.

I raised it again.

Thanks
Chanyeol

2014. 10. 29. =EC=98=A4=EC=A0=84 2:32=EC=97=90 &= quot;Marcel Holtmann" <marce= l@holtmann.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1:

Hi Chan-yeol,

> __hci_cmd_sync_ev(), __hci_req_sync() could miss wake_up_interrupt fro= m
> hci_req_sync_complete() because hci_cmd_work() workquee and its repons= e
> could be completed before they are ready to get the signal through
> add_wait_queue(), set_current_state(TASK_INTERRUPTIBLE).
>
> Signed-off-by: Chan-yeol Park <chanyeol.park@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> net/bluetooth/hci_core.c | 18 +++++++++++-------
> 1 file changed, 11 insertions(+), 7 deletions(-)
>
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index cb05d7f..c008f1f 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -1147,13 +1147,15 @@ struct sk_buff *__hci_cmd_sync_ev(struct hci_d= ev *hdev, u16 opcode, u32 plen,
>
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 hdev->req_status =3D HCI_REQ_PEND;
>
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0err =3D hci_req_run(&req, hci_req_sync= _complete);
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0if (err < 0)
> -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0return ERR_PTR= (err);
> -

the whole patch has whitespace damages. Please fix this.

Regards

Marcel

--
To unsubscribe from this list: send the line "unsubscribe linux-blueto= oth" in
the body of a message to major= domo@vger.kernel.org
More majordomo info at=C2=A0 http://vger.kernel.org/majordomo-info.html

--bcaec51a77c8dab9b60506b296b0--