Return-Path: MIME-Version: 1.0 In-Reply-To: References: <1414624583-29236-1-git-send-email-lukasz.rymanowski@tieto.com> Date: Thu, 30 Oct 2014 16:09:55 +0100 Message-ID: Subject: Re: [PATCH 1/2] shared/hfp: Remove reduntant check From: Lukasz Rymanowski To: Marcin Kraglak Cc: "linux-bluetooth@vger.kernel.org development" Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Marcin, Szymon, On 30 October 2014 11:11, Marcin Kraglak wrote: > Hi Lukasz, > > On 30 October 2014 00:16, Lukasz Rymanowski wrote: >> This check is not needed. Below memcmp check is sufficient >> --- >> src/shared/hfp.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/src/shared/hfp.c b/src/shared/hfp.c >> index 22e9622..f5a812d 100644 >> --- a/src/shared/hfp.c >> +++ b/src/shared/hfp.c >> @@ -135,9 +135,6 @@ static bool match_handler_prefix(const void *a, const void *b) >> const struct cmd_handler *handler = a; >> const char *prefix = b; >> >> - if (strlen(handler->prefix) != strlen(prefix)) >> - return false; >> - >> if (memcmp(handler->prefix, prefix, strlen(prefix))) >> return false; > it is incorrect in case prefix is sub-string of handler->prefix strcmp will do the work here. \Lukasz >> >> -- >> 1.8.4 >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > > BR > Marcin