Return-Path: From: Arman Uguray To: linux-bluetooth@vger.kernel.org Cc: Arman Uguray Subject: [PATCH BlueZ v1 2/7] shared/gatt-client: Fix bug in service changed handling. Date: Mon, 27 Oct 2014 07:35:37 -0700 Message-Id: <1414420542-15336-3-git-send-email-armansito@chromium.org> In-Reply-To: <1414420542-15336-1-git-send-email-armansito@chromium.org> References: <1414420542-15336-1-git-send-email-armansito@chromium.org> Sender: linux-bluetooth-owner@vger.kernel.org List-ID: This patch fixes a bug where the upper layer never got notified of a service changed event if no new services are added within a changed service range. This also fixes a bug where an empty changed service list or ATT error caused pending service changed events to not get processed. --- src/shared/gatt-client.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/shared/gatt-client.c b/src/shared/gatt-client.c index faae71c..8689368 100644 --- a/src/shared/gatt-client.c +++ b/src/shared/gatt-client.c @@ -961,20 +961,20 @@ static void service_changed_complete(struct discovery_op *op, bool success, { struct bt_gatt_client *client = op->client; struct service_changed_op *next_sc_op; - uint16_t start_handle, end_handle; + uint16_t start_handle = 0, end_handle = 0; client->in_svc_chngd = false; - if (!success) { + if (!success && att_ecode != BT_ATT_ERROR_ATTRIBUTE_NOT_FOUND) { util_debug(client->debug_callback, client->debug_data, "Failed to discover services within changed range - " "error: 0x%02x", att_ecode); - return; + goto next; } /* No new services in the modified range */ if (!op->result_head || !op->result_tail) - return; + goto next; start_handle = op->result_head->service.start_handle; end_handle = op->result_tail->service.end_handle; @@ -984,6 +984,7 @@ static void service_changed_complete(struct discovery_op *op, bool success, service_list_insert_services(&client->svc_head, &client->svc_tail, op->result_head, op->result_tail); +next: /* Notify the upper layer of changed services */ if (client->svc_chngd_callback) client->svc_chngd_callback(start_handle, end_handle, @@ -999,7 +1000,7 @@ static void service_changed_complete(struct discovery_op *op, bool success, } /* Check if the GATT service is not present or has remained unchanged */ - if (!client->svc_chngd_val_handle || + if (!start_handle || !client->svc_chngd_val_handle || client->svc_chngd_val_handle < start_handle || client->svc_chngd_val_handle > end_handle) return; -- 2.1.0.rc2.206.gedb03e5