Return-Path: <cyrus@holtmann.org>
Message-ID: <1413551445.2705.152.camel@jrissane-mobl.ger.corp.intel.com>
Subject: Re: [PATCH] Bluetooth: 6lowpan: remove unnecessary codes in
 give_skb_to_upper
From: Jukka Rissanen <jukka.rissanen@linux.intel.com>
To: roy.qing.li@gmail.com
Cc: linux-bluetooth@vger.kernel.org, marcel@holtmann.org,
 gustavo@padovan.org,  johan.hedberg@gmail.com
Date: Fri, 17 Oct 2014 16:10:45 +0300
In-Reply-To: <1413426115-17077-1-git-send-email-roy.qing.li@gmail.com>
References: <1413426115-17077-1-git-send-email-roy.qing.li@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
List-ID: <linux-bluetooth.vger.kernel.org>

Hi,

On to, 2014-10-16 at 10:21 +0800, roy.qing.li@gmail.com wrote:
> From: Li RongQing <roy.qing.li@gmail.com>
> 
> netif_rx() only returns NET_RX_DROP and NET_RX_SUCCESS, not returns
> negative value
> 
> Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
> ---
>  net/bluetooth/6lowpan.c |    9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/net/bluetooth/6lowpan.c b/net/bluetooth/6lowpan.c
> index c2e0d14..9b5c89b 100644
> --- a/net/bluetooth/6lowpan.c
> +++ b/net/bluetooth/6lowpan.c
> @@ -249,19 +249,12 @@ static struct lowpan_dev *lookup_dev(struct l2cap_conn *conn)
>  static int give_skb_to_upper(struct sk_buff *skb, struct net_device *dev)
>  {
>  	struct sk_buff *skb_cp;
> -	int ret;
>  
>  	skb_cp = skb_copy(skb, GFP_ATOMIC);
>  	if (!skb_cp)
>  		return -ENOMEM;
>  
> -	ret = netif_rx(skb_cp);
> -	if (ret < 0) {
> -		BT_DBG("receive skb %d", ret);
> -		return NET_RX_DROP;
> -	}
> -
> -	return ret;
> +	return netif_rx(skb_cp);
>  }
>  
>  static int process_data(struct sk_buff *skb, struct net_device *netdev,

Ack to this.

Signed-off-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>


Cheers,
Jukka