Return-Path: MIME-Version: 1.0 In-Reply-To: <2F926C4D-DBA0-4B6C-A368-FD8E95509A5A@holtmann.org> References: <1413037644-15858-1-git-send-email-fons@spotify.com> <2F926C4D-DBA0-4B6C-A368-FD8E95509A5A@holtmann.org> From: Alfonso Acosta Date: Sat, 11 Oct 2014 23:44:43 +0200 Message-ID: Subject: Re: [PATCH v5] Bluetooth: Defer connection-parameter removal when unpairing To: Marcel Holtmann Cc: BlueZ development Content-Type: text/plain; charset=UTF-8 List-ID: Hi Marcel, > I would have put an extra comment here as well to remind us that conn is for indicating to terminate the connection or not. See my review of v4 of your patch. > >> if (!conn) { >> err = cmd_complete(sk, hdev->id, MGMT_OP_UNPAIR_DEVICE, 0, >> &rp, sizeof(rp)); Ops, I missed that one. v6 includes the comment. Thanks, Fons -- Alfonso Acosta Embedded Systems Engineer at Spotify Birger Jarlsgatan 61, Stockholm, Sweden http://www.spotify.com