Return-Path: Message-ID: <1412763863.2705.22.camel@jrissane-mobl.ger.corp.intel.com> Subject: Re: [PATCH bluetooth-next] 6lowpan: Use pskb_expand_head in IPHC decompression. From: Jukka Rissanen To: Martin Townsend Cc: linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org, marcel@holtmann.org, alex.aring@gmail.com Date: Wed, 08 Oct 2014 13:24:23 +0300 In-Reply-To: <543408B2.1070309@xsilon.com> References: <1412696037-25111-1-git-send-email-martin.townsend@xsilon.com> <1412696037-25111-2-git-send-email-martin.townsend@xsilon.com> <543408B2.1070309@xsilon.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 List-ID: Hi Martin, tried to v2 of the patch and still see oops but not with the locking at this time. I had kmemleak activated in my kernel in this run. On ti, 2014-10-07 at 16:37 +0100, Martin Townsend wrote: > I should also mention this has only been compile tested as I currently don't have a way of testing it easily. So I would appreciate any testing on real HW. > > Jukka, I would be very interested to see if you see that locking error message you were seeing previously. > > - Martin. > [ 243.774232] kmemleak: Cannot insert 0xf45bde40 into the object search tree (overlaps existing) [ 243.775060] CPU: 0 PID: 0 Comm: swapper/0 Not tainted 3.17.0-rc1-bt6lowpan #1 [ 243.775060] Hardware name: innotek GmbH VirtualBox/VirtualBox, BIOS VirtualBox 12/01/2006 [ 243.775060] f45bde40 00000000 f600bb74 c18821c1 e716a0c8 f600bba8 c116abac c1ae324c [ 243.775060] f45bde40 00200282 e716a0f4 00000010 00000010 e716a134 00000000 f45bde40 [ 243.775060] f6001c00 f6001c00 f600bbd4 c187f10c 00000020 f600bbd4 00200246 f47805c0 [ 243.775060] Call Trace: [ 243.775060] [] dump_stack+0x4b/0x75 [ 243.775060] [] create_object+0x22c/0x280 [ 243.775060] [] kmemleak_alloc+0x3c/0xb0 [ 243.775060] [] kmem_cache_alloc+0x1a3/0x290 [ 243.775060] [] ? skb_clone+0x40/0xa0 [ 243.775060] [] skb_clone+0x40/0xa0 [ 243.775060] [] netlink_broadcast_filtered+0x25b/0x310 [ 243.775060] [] netlink_broadcast+0x2e/0x40 [ 243.775060] [] nlmsg_notify+0xbe/0xd0 [ 243.775060] [] rtnl_notify+0x3f/0x60 [ 243.775060] [] inet6_rt_notify+0xe2/0x150 [ 243.775060] [] fib6_add+0x388/0x7c0 [ 243.775060] [] ip6_ins_rt+0x53/0x70 [ 243.775060] [] ip6_pol_route.isra.42+0x2d8/0x3e0 [ 243.775060] [] ip6_pol_route_input+0x33/0x40 [ 243.775060] [] ? ip6_pol_route.isra.42+0x3e0/0x3e0 [ 243.775060] [] fib6_rule_action+0x79/0x1a0 [ 243.775060] [] fib_rules_lookup+0x117/0x1a0 [ 243.775060] [] ? fib_rules_net_init+0x30/0x30 [ 243.775060] [] fib6_rule_lookup+0x3b/0x70 [ 243.775060] [] ? ip6_pol_route.isra.42+0x3e0/0x3e0 [ 243.775060] [] ip6_route_input_lookup.isra.39+0x46/0x50 [ 243.775060] [] ? ip6_pol_route.isra.42+0x3e0/0x3e0 [ 243.775060] [] ip6_route_input+0x9d/0xb0 [ 243.775060] [] ip6_rcv_finish+0x147/0x1d0 [ 243.775060] [] ipv6_rcv+0x686/0xa10 [ 243.775060] [] ? __netif_receive_skb_core+0x4ab/0x7b0 [ 243.775060] [] __netif_receive_skb_core+0x4ab/0x7b0 [ 243.775060] [] ? __netif_receive_skb_core+0x59/0x7b0 [ 243.775060] [] __netif_receive_skb+0x1b/0x70 [ 243.775060] [] process_backlog+0x9f/0x140 [ 243.775060] [] net_rx_action+0x128/0x250 [ 243.775060] [] __do_softirq+0xd4/0x300 [ 243.775060] [] ? __local_bh_enable_ip+0xf0/0xf0 [ 243.775060] [] do_softirq_own_stack+0x2c/0x40 [ 243.775060] [] irq_exit+0x86/0xb0 [ 243.775060] [] smp_apic_timer_interrupt+0x38/0x50 [ 243.775060] [] apic_timer_interrupt+0x32/0x38 [ 243.775060] [] ? resched_cpu+0x7b/0x80 [ 243.775060] [] ? tick_nohz_idle_enter+0x4a/0x80 [ 243.775060] [] cpu_startup_entry+0x35/0x370 [ 243.775060] [] ? preempt_count_add+0x4b/0xa0 [ 243.775060] [] rest_init+0xa1/0xb0 [ 243.775060] [] start_kernel+0x386/0x38b [ 243.775060] [] i386_start_kernel+0x79/0x7d [ 243.775060] kmemleak: Kernel memory leak detector disabled [ 243.775060] kmemleak: Object 0xf45bde40 (size 192): [ 243.775060] kmemleak: comm "softirq", pid 0, jiffies 4294911070 [ 243.775060] kmemleak: min_count = 1 [ 243.775060] kmemleak: count = 0 [ 243.775060] kmemleak: flags = 0x1 [ 243.775060] kmemleak: checksum = 0 [ 243.775060] kmemleak: backtrace: [ 243.775060] [] kmemleak_alloc+0x3c/0xb0 [ 243.775060] [] kmem_cache_alloc+0x1a3/0x290 [ 243.775060] [] __alloc_skb+0x41/0x1c0 [ 243.775060] [] inet6_rt_notify+0x55/0x150 [ 243.775060] [] fib6_add+0x388/0x7c0 [ 243.775060] [] ip6_ins_rt+0x53/0x70 [ 243.775060] [] ip6_pol_route.isra.42+0x2d8/0x3e0 [ 243.775060] [] ip6_pol_route_input+0x33/0x40 [ 243.775060] [] fib6_rule_action+0x79/0x1a0 [ 243.775060] [] fib_rules_lookup+0x117/0x1a0 [ 243.775060] [] fib6_rule_lookup+0x3b/0x70 [ 243.775060] [] ip6_route_input_lookup.isra.39 +0x46/0x50 [ 243.775060] [] ip6_route_input+0x9d/0xb0 [ 243.775060] [] ip6_rcv_finish+0x147/0x1d0 [ 243.775060] [] ipv6_rcv+0x686/0xa10 [ 243.775060] [] __netif_receive_skb_core+0x4ab/0x7b0 [ 244.044145] BUG: unable to handle kernel NULL pointer dereference at 0000006c [ 244.044227] IP: [] __kmalloc_track_caller+0xb0/0x2b0 [ 244.044227] *pde = 00000000 [ 244.044227] Oops: 0000 [#1] PREEMPT SMP [ 244.044227] Modules linked in: bluetooth_6lowpan 6lowpan rfcomm bnep ecb btusb bluetooth nfc rfkill snd_intel8x0 parport_pc ohci_pci snd_ac97_codec ac97_bus parport Cheers, Jukka