Return-Path: <cyrus@holtmann.org>
From: Szymon Janc <szymon.janc@tieto.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] android/core: Fix memory leak in parse_system_id()
Date: Thu, 02 Oct 2014 16:47:32 +0200
Message-ID: <4430593.SCUzDF85ib@uw000953>
In-Reply-To: <1412260297-6200-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
References: <1412260297-6200-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Sender: linux-bluetooth-owner@vger.kernel.org
List-ID: <linux-bluetooth.vger.kernel.org>

Hi Andrei,

On Thursday 02 of October 2014 17:31:37 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> 
> get_prop() allocates memory which needs to be freed.
> ---
>  android/main.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/android/main.c b/android/main.c
> index 4f3a6bf..703b3b6 100644
> --- a/android/main.c
> +++ b/android/main.c
> @@ -382,9 +382,11 @@ static void parse_system_id(uint16_t len, const uint8_t *val)
>  
>  	res = strtoull(id, NULL, 16);
>  	if (res == ULLONG_MAX && errno == ERANGE)
> -		return;
> +		goto done;
>  
>  	config_system_id = res;
> +done:
> +	free(id);
>  }
>  
>  static void configuration(const void *buf, uint16_t len)
> 

Patch applied, thanks.

-- 
Best regards, 
Szymon Janc