Return-Path: MIME-Version: 1.0 In-Reply-To: <1415996428-17528-1-git-send-email-armansito@chromium.org> References: <1415996428-17528-1-git-send-email-armansito@chromium.org> Date: Mon, 17 Nov 2014 11:48:42 +0200 Message-ID: Subject: Re: [PATCH BlueZ v3 0/6] Introduce tools/btgatt-server and other bug fixes. From: Luiz Augusto von Dentz To: Arman Uguray Cc: "linux-bluetooth@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Arman, On Fri, Nov 14, 2014 at 10:20 PM, Arman Uguray wrote: > This patch set introduces tools/btgatt-server. This tool serves as a > standalone demo of combining shared/gatt-db, shared/gatt-server, and a > listening L2CAP socket on the ATT channel. The tool exposes the GAP and > GATT services, as well as a Heart Rate service. It's possible to hide/unhide > the latter to test Service Changed events. > > The set also includes two small bug fixes for the way Service Changed > characteristics are handled by shared/gatt-client. > > *v1: Fixed Luiz's comments: > - Style fixes. > - Make certain attribute values cached directly in gatt-db. > - Added an ATT error response encoding API and packed struct. > > *v2: Change bt_att_encode_error_rsp to bt_att_send_error_rsp. > > *v3: Fixed Luiz's comments: > - Fix all compile warnings and linker errors that are seen when patches in > the set are compiled seperately. > - Move btgatt-server experimental. > > Fixed Michael's comments: > - Removed unnecessary memcpy after realloc. > > Arman Uguray (6): > tools/btgatt-server: Introduce btgatt-server. > tools/btgatt-server: Accept incoming connection and initialize server. > tools/btgatt-server: Populate the database. > tools/btgatt-server: Add command support and the notify command. > tools/btgatt-server: Add Heart Rate service simulation. > tools/btgatt-server: Add "heart-rate" command. > > .gitignore | 1 + > Makefile.tools | 11 +- > tools/btgatt-server.c | 1086 +++++++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 1095 insertions(+), 3 deletions(-) > create mode 100644 tools/btgatt-server.c > > -- > 2.1.0.rc2.206.gedb03e5 Applied, thanks. -- Luiz Augusto von Dentz