Return-Path: From: Szymon Janc To: Andrei Emeltchenko Cc: linux-bluetooth@vger.kernel.org Subject: Re: [PATCH] android/gatt: Fix incorrect attribute check Date: Mon, 10 Nov 2014 20:52:28 +0100 Message-ID: <2162054.YOOzTySYLJ@leonov> In-Reply-To: <1415610600-2984-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> References: <1415610600-2984-1-git-send-email-Andrei.Emeltchenko.news@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-bluetooth-owner@vger.kernel.org List-ID: Hi Andrei, On Monday 10 of November 2014 11:10:00 Andrei Emeltchenko wrote: > From: Andrei Emeltchenko > > --- > android/gatt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/android/gatt.c b/android/gatt.c > index 2fad5ee..086bb94 100644 > --- a/android/gatt.c > +++ b/android/gatt.c > @@ -4311,7 +4311,7 @@ static void handle_server_add_included_service(const > void *buf, uint16_t len) } > > include = gatt_db_get_attribute(gatt_db, cmd->included_handle); > - if (!service) { > + if (!include) { > status = HAL_STATUS_FAILED; > goto failed; > } Pushed. Thanks. -- BR Szymon Janc