Return-Path: Date: Thu, 6 Nov 2014 20:26:42 +0100 From: Alexander Aring To: Martin Townsend Cc: linux-wpan@vger.kernel.org, linux-bluetooth@vger.kernel.org, jukka.rissanen@linux.intel.com, marcel@holtmann.org Subject: Re: [PATCHv2 bluetooth-next] 6lowpan: move skb_free from error paths in decompression Message-ID: <20141106192639.GC2321@omega> References: <1415301313-32290-1-git-send-email-mtownsend1973@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <1415301313-32290-1-git-send-email-mtownsend1973@gmail.com> List-ID: Hi Martin, On Thu, Nov 06, 2014 at 07:15:13PM +0000, Martin Townsend wrote: > Currently we ensure that the skb is freed on every error path in IPHC > decompression which makes it easy to introduce skb leaks. By centralising > the skb_free into the receive function it makes future decompression routines > easier to maintain. It does come at the expense of ensuring that the skb > passed into the decompression routine must not be copied. > > Signed-off-by: Martin Townsend so far I understand is that Jukka already acked this patch. So you could also add Acked-by: Jukka ... before sending this patch. Nevertheless you will have also an ack from me now: Acked-by: Alexander Aring - Alex